Minor atoms improvements #7145
Merged
Minor atoms improvements #7145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7145-lucasatoms-improvements |
lucasmerlin
commented
Jun 14, 2025
| @@ -82,7 +82,7 @@ impl<'a> Atoms<'a> { | |||
| }) | |||
| } | |||
|
|
|||
| pub fn iter_texts(&'a self) -> impl Iterator<Item = &'a WidgetText> { | |||
| pub fn iter_texts(&self) -> impl Iterator<Item = &WidgetText> + use<'_, 'a> { | |||
There was a problem hiding this comment.
These use bounds were new to me but it makes perfect sense.
The concrete return type would be something like FilterMap<Iter<Item=AtomKind<'a> ...> but since WidgetText doesn't have a lifetime this information gets lost. With use we specify the actual lifetime requirements and it compiles.
emilk
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve some lifetime bounds and add some convenience constructors