-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ScrollArea
improvements for user configurability
#5443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview available at https://egui-pr-preview.github.io/pr/5443-scroll-area-adjustments |
Hey @emilk, sorry to bother you, but how can I fix this PR so that it can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this one! Looks great, but needs to merge in latest master
Shall I rebase to latest master, or is there anything else needed? |
No, just rebase or merge in latest |
188bc8c
to
afce459
Compare
I rebased the branch and checked that the demo app still works the same. So is it ready to merge? |
There is a bunch of CI failures |
I fixed the warnings that I could see in the CI, but now there is a conflict which I do not seem to have the right to resolve. |
I seem to have resolved the conflict though I do not understand how I did it (I see the merge of master, but I do not know why it was necessary). |
ScrollArea
adjustments for better configuration/customization #5406The changes follow what is described in the issue with a couple changes:
ScrollArea::scroll_bar_visibility()
has to be used, this is as not to limit the user configurability by imposing a specific function. The user might want to retain the scrollbars visibility to show the current position.InputState::smooth_scroll_delta
and notPassState::scroll_delta
, therefore it is possible to prevent scrolling by setting theInputState::smooth_scroll_delta
to zero before painting theScrollArea
.A simple demo is available at https://github.com/MStarha/egui_scroll_area_test