Nicer looking text selection, especially in light mode #5017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
486c
pushed a commit
to 486c/egui
that referenced
this pull request
Oct 9, 2024
* Closes emilk#4727 This changes the text selection painting from being painted on top of the text, to being painted behind the text, but in front of any text background. The result is much nicer looking text selection, especially in light mode: ### The new selections <img width="198" alt="Screenshot 2024-08-27 at 18 58 35" src="https://github.com/user-attachments/assets/bd342946-299c-44ab-bc2d-2aa8ddbca8eb"> <img width="187" alt="Screenshot 2024-08-27 at 18 59 26" src="https://github.com/user-attachments/assets/352bed32-5150-49b9-a9f9-c7679a0d30b2"> ### What selections used to look like <img width="143" alt="Screenshot 2024-08-27 at 19 03 08" src="https://github.com/user-attachments/assets/f3cbd798-cfed-4ad4-aa3a-d7480efcfa3c"> <img width="143" alt="Screenshot 2024-08-27 at 19 03 23" src="https://github.com/user-attachments/assets/9925d18d-da82-4a44-8a98-ea6857ecc14f"> ### New selection of some text with a background <img width="134" alt="Screenshot 2024-08-27 at 18 59 12" src="https://github.com/user-attachments/assets/1d291d7f-efbd-4efd-b6d2-cd63c9fc4fa4">
hacknus
pushed a commit
to hacknus/egui
that referenced
this pull request
Oct 30, 2024
* Closes emilk#4727 This changes the text selection painting from being painted on top of the text, to being painted behind the text, but in front of any text background. The result is much nicer looking text selection, especially in light mode: ### The new selections <img width="198" alt="Screenshot 2024-08-27 at 18 58 35" src="https://github.com/user-attachments/assets/bd342946-299c-44ab-bc2d-2aa8ddbca8eb"> <img width="187" alt="Screenshot 2024-08-27 at 18 59 26" src="https://github.com/user-attachments/assets/352bed32-5150-49b9-a9f9-c7679a0d30b2"> ### What selections used to look like <img width="143" alt="Screenshot 2024-08-27 at 19 03 08" src="https://github.com/user-attachments/assets/f3cbd798-cfed-4ad4-aa3a-d7480efcfa3c"> <img width="143" alt="Screenshot 2024-08-27 at 19 03 23" src="https://github.com/user-attachments/assets/9925d18d-da82-4a44-8a98-ea6857ecc14f"> ### New selection of some text with a background <img width="134" alt="Screenshot 2024-08-27 at 18 59 12" src="https://github.com/user-attachments/assets/1d291d7f-efbd-4efd-b6d2-cd63c9fc4fa4">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the text selection painting from being painted on top of the text, to being painted behind the text, but in front of any text background. The result is much nicer looking text selection, especially in light mode:
The new selections
What selections used to look like
New selection of some text with a background