Correct ember-source compatibility for 3.x #214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 3.x line of ember-cli-deprecation-workflow specifies a peer dependency of ember-source >= 4.0.0 and does not work with ember-source 3.28.x
|
FWIW v3 does actually work with Ember 3.28, it is just that there is no test coverage and so the peerDep says only 4.x is supported. I'm using 3.x in an Ember 3.28 app right now :-/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just tried to use ember-cli-deprecation-workflow with an Ember 3.28.12 project, but it doesn't meet the peerDependency of ember-source >= 4.0.0
ember-cli-deprecation-workflow/package.json
Lines 78 to 80 in d70f32b
Updated the readme to make it clearer that ember-source 3.28 projects should use the 2.x line of this addon