Created Danish keyboard layout

[MagicBOTAlex]

Issue [#80]

I told ya I would do it.
Kept my word.

This repo is surprisingly well organized. Good job

[elvissteinjr]

Mostly looks good, so I'm being pedantic in places here.
Some is opinionated and I don't know what a typical danish keyboard really looks like beyond what the internet tells me (which sometimes fools me on this topic).

Really blocking would only be the Enter key type.
Thanks!

[MagicBOTAlex]

I'll be doing these changes in the near future, but tomorrow, uni starts again. And I foolishly choose double work so I can finish Uni faster. Thanks for feedback though. Idk, I'm just wandering around in this repo lol.

[MagicBOTAlex]

Here's the layout but in screenshots, so easier for you to review:

normal

Shift

AltGr

Idk what happens with the numpad in altGr because I don't have a numpad lol

[elvissteinjr]

Idk what happens with the numpad in altGr because I don't have a numpad lol
What we had previously there was fine. Numpad should send numpad key codes in the AltGr layer as well. Software can decide what to do with that, though I guess it's usually not much.

Looks good to me otherwise.

[MagicBOTAlex]

Oh, i read it wrong. I'll correct it next time

[MagicBOTAlex]

Alright, how about this?

This is the AltGr layout

Sorry for this long wait. Life has been busy

[elvissteinjr]

Looks mostly good to me.

If you don't mind me being pedantic one last time, the numpad decimal/comma is missing on the AltGr layer. Checking with an input tester, there doesn't seem to be anything unusual with the key states of the numpad keys while holding AltGr on a real keyboard, so it'd make sense for all of them to remain available.

Also something I missed last time, the "" key's string seems to be set to print "\", so two characters. If there was an intent of escaping here, that is not necessary (only escaped things are newlines are as "\n" and literal "\n"s as "\n").

Don't worry about the speed of progress here. It's not like much has happened from my side recently either.

[MagicBOTAlex]

I somehow got merge conflics with myself. this github is weird.
Anyway, hopefully this is the correct version.

Please tell if there is anything wrong. i'll fix it when i get time again lol

[elvissteinjr]

Right. So as nice of a gesture it is, I don't think I should be listed in the author field. My input on this layout isn't really worth crediting.

The "" in the AltGr layout still types double characters. This and above would be my last nitpick.
Honestly if I could I'd make those quick edits myself and be done with it. Doesn't seem how GitHub wants things to be if I want your authorship history in, though, so I guess not.

Something else that is on me is that it seems that the typing of some characters with different OS keyboard layout doesn't work as intended. Weirdly enough hadn't run into that with other international layouts yet, but there's nothing wrong in the layout file here.
But that's not a blocker or anything, and I'll look into that when I have time. I assume it's already working fine with a matching keyboard layout set in the OS, which would be the primary user base.

[MagicBOTAlex]

ohhh, i thought there was some typo at "". But I tried to fix that, but the merge conflict redid it for some reason.
We're talking about the backslash right?

I think I've might have found some bug.

Having \\ as a string make it write: \\
But with \, it writes ' for some reason. This is definitely wrong.
The virtual key number is 226. I tried to use the vkey option too, but it results in ;

Yes, I checked multiple times that I was using danish system keyboard layout:

I guess the reason I left it at \\ back then was because at least I could use it then backspace as a comprimise. But I forgot.

[MagicBOTAlex]

No wait, there might be something wrong with my computer right now

[MagicBOTAlex]

Okay, I'm angry. It works again after restarting Desktop+.
Here's the fixed changes then

[MagicBOTAlex]

Right. So as nice of a gesture it is, I don't think I should be listed in the author field. My input on this layout isn't really worth crediting.

You're a nice person, and you've pointed out a lot of my errors.

Doesn't seem how GitHub wants things to be if I want your authorship history in, though, so I guess not.

Honestly, when I began this keyboard thing, I needed it for my CV. But now, it doesn't matter as much.
Now it's mosty to help out my other danish homies.

I think if you squash the commits, then it will become a single commit with you as credited. With me in the desc.
But if you just merge, then each of mine commits + your commits. But this git thing is always confusing for me too.

[elvissteinjr]

Some more string keys to inputs not working properly is unfortunate (VkKeyScanW() is used and supposed to return the right key codes for current OS layout), but something I'll need to look into myself as said.

The layout as it is now is fine. Might jump in and adjust the affected keys later if I figure anything out, but no need to worry on it for now.
Squash and merge should still keep you as the author (did for the Japanese translation pull request). We'll see in a second I suppose.

Thanks again for your contribution!