Skip to content

This adds in logging for parameters #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2017
Merged

This adds in logging for parameters #75

merged 2 commits into from
May 18, 2017

Conversation

veverkap
Copy link
Contributor

I found in my testing that it would be helpful to include logging in the DebugLogger of the params

@teamon
Copy link
Member

teamon commented May 17, 2017

Thanks @veverkap!

The only thing I'd change is to use the name "query" or "query params" or "query attributes" instead of just "params" to not introduce confusion with body params.

@veverkap
Copy link
Contributor Author

veverkap commented May 17, 2017 via email

@veverkap
Copy link
Contributor Author

@teamon I've changed it to

 _ = Logger.debug "#{prefix} Query Param '#{k}': '#{v}'"

HTH

@teamon teamon merged commit 53be04a into elixir-tesla:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants