Support profile for httpc adapter
#655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanguilp
changed the title
profile for httpc adapterprofile for httpc adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpc:request/5function can be used to indicate a profile to use. It's particularly useful to set up proxies (socks & http) and that's actually the only way.This PR refactors the
httpcadapter to use, when present, the profile in the options passed as a parameter when setting up the adapter in the client.Setting up the profile is to be done separately (see the test file).
The test is a bit weak because I could not find a way to actually make sure the profile is used. However, the whole thing crashes when the profile is not set up, so I guess it's quite ok.