Replace get_env with compile_env in module body & minor enhancement with version upgrade.

[uzairaslam196]

close #579

Changes:

1. Replace Application.get_env with Application.compile_env in Tesla.Middleware.Logger.Formatter & Tesla.Middleware.Telemetry modules.
2. Put prefix with unused vars.
3. Upgrade Elixir version to ~> 1.10.
4. Upgrade Tesla version to 1.7.0.

[yordis]

Do you mind bumping the version in the mix.exs

tesla/mix.exs

Line 5 in 30c3a29

@version "1.6.1"

[whatyouhide]

You cannot do this while Tesla depends on Elixir ~> 1.7, since the compile_env functions were introduced in 1.10. I would recommend doing it conditionally:

# TODO: remove once we depend on Elixir 1.10+.
if function_exported?(Application, :compile_env, 3) do
  @config Application.compile_env(:tesla, __MODULE__, [])
else
  @config Application.get_env(:tesla, __MODULE__, [])
end

[uzairaslam196]

You cannot do this while Tesla depends on Elixir ~> 1.7, since the compile_env functions were introduced in 1.10. I would recommend doing it conditionally:

# TODO: remove once we depend on Elixir 1.10+.
if function_exported?(Application, :compile_env, 3) do
  @config Application.compile_env(:tesla, __MODULE__, [])
else
  @config Application.get_env(:tesla, __MODULE__, [])
end

I have made changes accordingly. Please review

[uzairaslam196]

Do you mind bumping the version in the mix.exs

tesla/mix.exs

Line 5 in 30c3a29

@version "1.6.1"

@yordis what should be new version, i need your guidance on it. Should it be 1.6.2?

[yordis]

Related to #581 (comment)

I am OK change the supported Elixir version to be higher and follow a bit https://hexdocs.pm/elixir/compatibility-and-deprecations.html

@whatyouhide any objections?!

[whatyouhide]

@yordis absolutely not! I was just warning against a breaking change, but raising the required Elixir version to 1.10 is great, it's been around for quite a while now!

[yordis]

@whatyouhide I think I tried to say what you said 😄

@uzairaslam196 bump the version of elixir

tesla/mix.exs

Line 13 in 30c3a29

elixir: "~> 1.7",

to be ~> 1.10 and the version

tesla/mix.exs

Line 5 in 30c3a29

@version "1.6.1"

to be 1.7.0

We wouldn't need to check for the func existence after that.

[uzairaslam196]

@whatyouhide I think I tried to say what you said 😄

@uzairaslam196 bump the version of elixir

tesla/mix.exs

Line 13 in 30c3a29

elixir: "~> 1.7",

to be ~> 1.10 and the version

tesla/mix.exs

Line 5 in 30c3a29

@version "1.6.1"

to be 1.7.0
We wouldn't need to check for the func existence after that.

I got it. 😄

[uzairaslam196]

@yordis i pushed new changes after upgrading versions, test cases are running fine.
I used Elixir 1.12.3 with Erlang/OTP 24 locally.

[yordis]

Suggested change

	@disable_legacy_event Application.compile_env(:tesla, Tesla.Middleware.Telemetry,
	disable_legacy_event: false)[:disable_legacy_event]
	@disable_legacy_event Application.compile_env(:tesla [Tesla.Middleware.Telemetry, :disable_legacy_event], false)

I think this is a clearer implementation.

[uzairaslam196]

Yes, I agree. Thanks for enhancement.

[yordis]

@whatyouhide share some Code Review love 🙏🏻

@uzairaslam196 thank you so much for the help!

[whatyouhide]

Looks good to me too, but I'd merge #581 first so that this one can bump the version only once 🙃