Skip to content

Add code formatting check to travis matrix #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

amatalai
Copy link
Collaborator

Formatter does not change not foo in bar to foo not in bar anymore :)
I can also open PR to branch 1.0 if you prefer.

@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #169   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files          21       21           
  Lines         420      420           
=======================================
  Hits          413      413           
  Misses          7        7
Impacted Files Coverage Δ
lib/tesla/middleware/follow_redirects.ex 100% <ø> (ø) ⬆️
lib/tesla/middleware/method_override.ex 100% <100%> (ø) ⬆️
lib/tesla.ex 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec8b6c...2d4cb57. Read the comment docs.

@teamon
Copy link
Member

teamon commented Feb 16, 2018

I'd merge that, but I have similar changes in 1.0 branch. Let's keep it open and I'll apply the changes manually, thanks!

@teamon teamon added this to the 1.0 milestone Feb 16, 2018
@teamon teamon added blocked and removed blocked labels Mar 5, 2018
@teamon
Copy link
Member

teamon commented Mar 14, 2018

Applies into 1.0, thanks!

@teamon teamon closed this Mar 14, 2018
@amatalai amatalai deleted the ci-formatting-check branch June 20, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants