Skip to content

Removing useless rescue clause on Timeout middleware #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

HugoLnx
Copy link

@HugoLnx HugoLnx commented Feb 11, 2018

Just removing a useless rescue clause from Timeout middleware. When I coded this method in the project I worked with @emerleite, I didn't know that catch also works for raised exceptions.

PS.: No test added because this is a refactoring, this code are already tested on: timeout_test.exs#L99

@codecov
Copy link

codecov bot commented Feb 11, 2018

Codecov Report

Merging #166 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   98.33%   98.32%   -0.01%     
==========================================
  Files          21       21              
  Lines         420      419       -1     
==========================================
- Hits          413      412       -1     
  Misses          7        7
Impacted Files Coverage Δ
lib/tesla/middleware/timeout.ex 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fec8b6c...a125133. Read the comment docs.

@emerleite
Copy link
Contributor

@HugoLnx makes sense. LGTM

@teamon
Copy link
Member

teamon commented Feb 16, 2018

Thanks! I will apply these changes to the 1.0 branch.

@teamon teamon added this to the 1.0 milestone Feb 16, 2018
@teamon teamon added blocked and removed blocked labels Mar 5, 2018
@teamon teamon added the chore label Mar 13, 2018
@teamon
Copy link
Member

teamon commented Mar 14, 2018

Fixed during other changes so this is not needed anymore. Thanks!

@teamon teamon closed this Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants