Add telemetry #31
Merged
Add telemetry #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregMefford
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
Looks good to me!
My only question/concern is whether this would catch errors raised from Erlang libraries, or only Exceptions thrown from Elixir code. The behavior would be the same in the existing code but with these telemetry events, it’s more critical to handle all cases because it might be the main way that people see that an error happened. I’m not at a computer to check ATM.
|
@GregMefford it handles both. |
bryannaegele
approved these changes
Apr 20, 2020
|
Third time's a charm! looks great Previous PRs: |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are nearing Phoenix v1.5 release, I think we should get this in before so we can apply similar changes to Phoenix.
It is very similar to @bryannaegele's PR with some changes:
The
connis given to all events - although exception emits a stale connectionI have renamed the event to
[:plug_adapter, :call, :start]. This is based on our previous discussions. Since I want this event to be generic in regards to the adapter, then I think it is best to name it based on Plug's contract. In other words, this event is triggered when the adapter calls the underlying Plug. For this reason, I am also passing the called plug as metadata.Please review it ASAP so I can apply these changes to Phoenix.
/cc @GregMefford @binaryseed @bryannaegele