Load PDF files

[darrelwright]

I am trying to open a PDF in Notes and it does not appear to load. Am I doing something wrong? I open Notes, set it for pdf, it acts like it loads but nothing is displayed.

Gods_plan_for_the_ages.pdf

[otseng]

I think notes can only display the text in pdf files. Your pdf file has no text in it.

[darrelwright]

Thanks Oliver, but is there any way to display and/or open PDF files?

…

On 4/12/21 2:45 AM, Oliver Tseng wrote: I think notes can only display the text in pdf files. Your pdf file has no text in it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXXZXEZIRXQM4ARCU4BGHTTIK6KPANCNFSM42XELBIA>.

[otseng]

@eliranwong what are your thoughts on adding full pdf support, instead of just loading the text?

[darrelwright]

anything happening yet? Just curious

[otseng]

I'll see if I can add full pdf support.

[otseng]

I was originally thinking of writing this as a plugin, but now I'm thinking of making it a feature of UBA. The ability to read pdf files opens the door to build a collection of pdf docs, just like we have for books and commentaries. This collection of pdf files would be in the pdf directory. Would create a Github repo of pdf files and ability to download them. Another tab would be added to the master control to be able to read the pdf files in the pdf directory.

[darrelwright]

Oliver, that would be awesome. It provides what I feel is a necessary enhancement!

…

On 4/17/21 6:27 PM, Oliver Tseng wrote: I was originally thinking of writing this as a plugin, but now I'm thinking of making it a feature of UBA. The ability to read pdf files opens the door to build a collection of pdf docs, just like we have for books and commentaries. This collection of pdf files would be in the pdf directory. Would create a Github repo of pdf files and ability to download them. Another tab would be added to the master control to be able to read the pdf files in the pdf directory. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXXZXEZVRSPMLIK33TQ3YTTJIYPNANCNFSM42XELBIA>.

[eliranwong]

I was originally thinking of writing this as a plugin, but now I'm thinking of making it a feature of UBA. The ability to read pdf files opens the door to build a collection of pdf docs, just like we have for books and commentaries. This collection of pdf files would be in the pdf directory. Would create a Github repo of pdf files and ability to download them. Another tab would be added to the master control to be able to read the pdf files in the pdf directory.

Thanks for working on it. That would be perfect if pdf is searchable in UBA.

[darrelwright]

Oh! I'm gonna start salivating!!!

…

On 4/17/21 10:23 PM, Eliran Wong wrote: I was originally thinking of writing this as a plugin, but now I'm thinking of making it a feature of UBA. The ability to read pdf files opens the door to build a collection of pdf docs, just like we have for books and commentaries. This collection of pdf files would be in the pdf directory. Would create a Github repo of pdf files and ability to download them. Another tab would be added to the master control to be able to read the pdf files in the pdf directory. Thanks for working on it. That would be perfect if pdf is searchable in UBA. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXXZXCK4WWQXGUOXCHNNFTTJJUGZANCNFSM42XELBIA>.

[darrelwright]

And prayerfully that there is not a size limit on the PDF?

…

On 4/17/21 10:23 PM, Eliran Wong wrote: I was originally thinking of writing this as a plugin, but now I'm thinking of making it a feature of UBA. The ability to read pdf files opens the door to build a collection of pdf docs, just like we have for books and commentaries. This collection of pdf files would be in the pdf directory. Would create a Github repo of pdf files and ability to download them. Another tab would be added to the master control to be able to read the pdf files in the pdf directory. Thanks for working on it. That would be perfect if pdf is searchable in UBA. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#361 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXXZXCK4WWQXGUOXCHNNFTTJJUGZANCNFSM42XELBIA>.

[otseng]

@eliranwong I created a branch for you to test out before merging:
https://github.com/eliranwong/UniqueBible/tree/pdf-merge

I used the pdf.js library to view pdf files:
http://mozilla.github.io/pdf.js/

It works quite well and has several nice features. It's also fast and from what I can tell there is no limit to the size of the file it can open. I tested with it with a PDF that has 1080 pages and it works.

But, the only drawback to it is it doesn't have dark mode support. I added a request here:
mozilla/pdf.js#2071 (comment)

I commented out line 47 in CentralWidget.py. Not sure what that line does, but if it's there, it opens an extra tab when viewing a pdf file.

You can download pdf files from the menu (Github PDF) which will pull it from:
https://github.com/otseng/UniqueBible_PDF

[eliranwong]

line 47 in CentralWidget.py

thanks. I will test. btw, line 47 in CentralWidget is useful ... I will check.

[eliranwong]

the pdf feature is awesome, more than I expected. thanks very much for adding this ...

does mozilla has something for epub like the pdf ?