-
-
Notifications
You must be signed in to change notification settings - Fork 1
Enable Kotlin and upgrade Java compile/target version for utils #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the Gradle build configuration to enable Kotlin support for the Android project. The modifications add the Kotlin Android plugin, set Changes
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
app/build.gradle (1)
65-66
: New Kotlin Dependency Declarations
The dependencies forandroidx.core.ktx
andandroidx.lifecycle.viewmodel.ktx
are correctly added. These dependencies will help leverage Kotlin extensions within the project. For consistency, consider using parentheses (i.e.implementation(libs.androidx.core.ktx)
) if it matches the rest of the dependency declarations.utils/build.gradle (1)
33-37
: Dependency Block Enhancements
The updated dependencies now includeimplementation libs.androidx.core.ktx
alongside existing dependencies. Note that on line 36, the inline comment lacks a preceding space; you might consider a minor formatting tweak for readability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
app/build.gradle
(3 hunks)gradle/libs.versions.toml
(2 hunks)utils/build.gradle
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build (windows-latest, 21)
- GitHub Check: build (windows-latest, 17)
- GitHub Check: build (macos-latest, 21)
- GitHub Check: build (macos-latest, 17)
- GitHub Check: build (ubuntu-latest, 21)
- GitHub Check: build (ubuntu-latest, 17)
🔇 Additional comments (8)
app/build.gradle (2)
1-3
: Kotlin Plugin Integration Added Correctly
The newplugins
block applyingalias(libs.plugins.kotlin.android)
enables Kotlin support as planned. This aligns well with the PR objective and modern Gradle practices.
38-40
: Kotlin Options Configuration Is Correct
The addition of thekotlinOptions
block withjvmTarget = '17'
ensures that your Kotlin code is compiled for Java 17 compatibility.utils/build.gradle (3)
1-5
: Kotlin Plugin Added for the Utils Module
The inclusion ofalias(libs.plugins.kotlin.android)
in the plugins block correctly enables Kotlin support within the utils module, ensuring consistency with the app module’s configuration.
24-27
: Java Compatibility Upgraded to Java 17
The update in thecompileOptions
block, setting bothsourceCompatibility
andtargetCompatibility
toJavaVersion.VERSION_17
, meets the PR objective to upgrade the Java version.
28-30
: Kotlin JVM Target Set Appropriately
The addition of thekotlinOptions
block withjvmTarget = '17'
ensures that Kotlin is compiled against Java 17, creating consistency with the Java compile options.gradle/libs.versions.toml (3)
17-19
: Version Catalog Updated for Kotlin and AndroidX Libraries
The new entries forcoreKtx
,lifecycleViewmodelKtx
, andkotlin
(with versions"1.15.0"
,"2.2.0"
, and"2.1.10"
, respectively) are correctly added. These version references will be used in the build files to maintain consistency and ease future upgrades.
41-42
: New Library Entries for AndroidX Kotlin Extensions
The library definitions forandroidx-core-ktx
andandroidx-lifecycle-viewmodel-ktx
correctly reference the newly added version entries. This change supports the dependency declarations in both the app and utils modules.
45-46
: Kotlin Android Plugin Entry Defined
The plugin entry forkotlin-android
is correctly added, ensuring the Gradle build system can resolve the Kotlin Android plugin and align with the version specified in the catalog.
Enable Kotlin and upgrade Java compile/target version for utils
Summary by CodeRabbit