Skip to content

Enable Kotlin and upgrade Java compile/target version for utils #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

tuancoltech
Copy link
Member

@tuancoltech tuancoltech commented Mar 3, 2025

Enable Kotlin and upgrade Java compile/target version for utils

Summary by CodeRabbit

  • New Features
    • Introduced enhanced Kotlin integration, updating language and library support for improved performance and compatibility on Android.
    • Upgraded underlying runtime settings to align with modern standards, ensuring a smoother and more robust experience.

Copy link

coderabbitai bot commented Mar 3, 2025

Walkthrough

The changes update the Gradle build configuration to enable Kotlin support for the Android project. The modifications add the Kotlin Android plugin, set kotlinOptions { jvmTarget = '17' }, and update Java compatibility to Java 17. Additionally, new dependencies for androidx.core.ktx (in both modules) and androidx.lifecycle.viewmodel.ktx (in the app module) are introduced. Version references and corresponding library/plugin entries for these components are added in the gradle/libs.versions.toml file.

Changes

File(s) Change Summary
app/build.gradle, utils/build.gradle • Added Kotlin plugin: alias(libs.plugins.kotlin.android)
• Introduced kotlinOptions { jvmTarget = '17' }
• Added dependency: implementation libs.androidx.core.ktx
• In app/build.gradle only: added dependency implementation libs.androidx.lifecycle.viewmodel.ktx
• Updated Java compatibility to VERSION_17 in utils/build.gradle
gradle/libs.versions.toml • Added version references: coreKtx = "1.15.0", lifecycleViewmodelKtx = "2.2.0", and kotlin = "2.1.10"
• Created library entries for androidx-core-ktx and androidx-lifecycle-viewmodel-ktx
• Added plugin entry for kotlin-android referencing the kotlin version

Suggested labels

dependencies

Suggested reviewers

  • gscdev
  • nya-elimu
  • jo-elimu

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
app/build.gradle (1)

65-66: New Kotlin Dependency Declarations
The dependencies for androidx.core.ktx and androidx.lifecycle.viewmodel.ktx are correctly added. These dependencies will help leverage Kotlin extensions within the project. For consistency, consider using parentheses (i.e. implementation(libs.androidx.core.ktx)) if it matches the rest of the dependency declarations.

utils/build.gradle (1)

33-37: Dependency Block Enhancements
The updated dependencies now include implementation libs.androidx.core.ktx alongside existing dependencies. Note that on line 36, the inline comment lacks a preceding space; you might consider a minor formatting tweak for readability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b546422 and 960cdef.

📒 Files selected for processing (3)
  • app/build.gradle (3 hunks)
  • gradle/libs.versions.toml (2 hunks)
  • utils/build.gradle (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build (windows-latest, 21)
  • GitHub Check: build (windows-latest, 17)
  • GitHub Check: build (macos-latest, 21)
  • GitHub Check: build (macos-latest, 17)
  • GitHub Check: build (ubuntu-latest, 21)
  • GitHub Check: build (ubuntu-latest, 17)
🔇 Additional comments (8)
app/build.gradle (2)

1-3: Kotlin Plugin Integration Added Correctly
The new plugins block applying alias(libs.plugins.kotlin.android) enables Kotlin support as planned. This aligns well with the PR objective and modern Gradle practices.


38-40: Kotlin Options Configuration Is Correct
The addition of the kotlinOptions block with jvmTarget = '17' ensures that your Kotlin code is compiled for Java 17 compatibility.

utils/build.gradle (3)

1-5: Kotlin Plugin Added for the Utils Module
The inclusion of alias(libs.plugins.kotlin.android) in the plugins block correctly enables Kotlin support within the utils module, ensuring consistency with the app module’s configuration.


24-27: Java Compatibility Upgraded to Java 17
The update in the compileOptions block, setting both sourceCompatibility and targetCompatibility to JavaVersion.VERSION_17, meets the PR objective to upgrade the Java version.


28-30: Kotlin JVM Target Set Appropriately
The addition of the kotlinOptions block with jvmTarget = '17' ensures that Kotlin is compiled against Java 17, creating consistency with the Java compile options.

gradle/libs.versions.toml (3)

17-19: Version Catalog Updated for Kotlin and AndroidX Libraries
The new entries for coreKtx, lifecycleViewmodelKtx, and kotlin (with versions "1.15.0", "2.2.0", and "2.1.10", respectively) are correctly added. These version references will be used in the build files to maintain consistency and ease future upgrades.


41-42: New Library Entries for AndroidX Kotlin Extensions
The library definitions for androidx-core-ktx and androidx-lifecycle-viewmodel-ktx correctly reference the newly added version entries. This change supports the dependency declarations in both the app and utils modules.


45-46: Kotlin Android Plugin Entry Defined
The plugin entry for kotlin-android is correctly added, ensuring the Gradle build system can resolve the Kotlin Android plugin and align with the version specified in the catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants