Skip to content

fix: vfs perf #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 27, 2025
Merged

fix: vfs perf #1332

merged 9 commits into from
Mar 27, 2025

Conversation

sgammon
Copy link
Member

@sgammon sgammon commented Mar 25, 2025

Draft Powered by Pull Request Badge

Summary

Fixes various issues related to VFS. More coming soon; depends on #1331. Also fixes Python import issues at main.

@sgammon sgammon added bug Something isn't working vfs Issues and PRs relating to virtual file system (VFS) features labels Mar 25, 2025
@sgammon sgammon added this to the Release R16: Beta milestone Mar 25, 2025
@sgammon sgammon self-assigned this Mar 25, 2025
@sgammon sgammon added this to Elide Mar 25, 2025
@sgammon sgammon moved this to In Progress in Elide Mar 25, 2025
@sgammon sgammon linked an issue Mar 25, 2025 that may be closed by this pull request
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 72.68908% with 130 lines in your changes missing coverage. Please review.

Project coverage is 51.94%. Comparing base (53faf97) to head (6309424).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...in/elide/runtime/plugins/AbstractLanguagePlugin.kt 59.21% 31 Missing ⚠️
.../runtime/gvm/internals/vfs/EmbeddedGuestVFSImpl.kt 61.90% 12 Missing and 4 partials ⚠️
...main/kotlin/elide/runtime/plugins/vfs/VfsPlugin.kt 57.69% 8 Missing and 3 partials ⚠️
...main/kotlin/elide/runtime/plugins/python/Python.kt 30.76% 8 Missing and 1 partial ⚠️
...main/kotlin/elide/runtime/plugins/env/EnvPlugin.kt 52.63% 7 Missing and 2 partials ⚠️
...elide/runtime/gvm/internals/vfs/AbstractBaseVFS.kt 22.22% 7 Missing ⚠️
...kotlin/elide/runtime/gvm/internals/vfs/VFSTypes.kt 53.33% 1 Missing and 6 partials ⚠️
...kotlin/elide/tool/cli/cmd/repl/ToolShellCommand.kt 70.00% 3 Missing and 3 partials ⚠️
...ages/cli/src/main/kotlin/elide/tool/cli/Statics.kt 50.00% 4 Missing ⚠️
.../graalvm/python/embedding/GraalPythonFilesystem.kt 0.00% 4 Missing ⚠️
... and 13 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
- Coverage   52.02%   51.94%   -0.08%     
==========================================
  Files         472      475       +3     
  Lines       18324    18786     +462     
  Branches     3407     3487      +80     
==========================================
+ Hits         9533     9759     +226     
- Misses       7679     7880     +201     
- Partials     1112     1147      +35     
Flag Coverage Δ
jvm 51.94% <72.68%> (-0.08%) ⬇️
lib 51.94% <72.68%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ide/runtime/gvm/internals/EngineThreadContext.java 0.00% <ø> (ø)
...src/main/kotlin/elide/runtime/core/EnginePlugin.kt 100.00% <ø> (ø)
.../kotlin/elide/runtime/diag/DiagnosticsContainer.kt 38.59% <100.00%> (ø)
...in/elide/runtime/plugins/AbstractLanguageConfig.kt 56.75% <100.00%> (ø)
...me/lang/javascript/ElideUniversalJsModuleLoader.kt 74.90% <ø> (ø)
...elide/runtime/gvm/kotlin/feature/KotlinResource.kt 0.00% <ø> (ø)
...otlin/elide/runtime/plugins/python/PythonConfig.kt 100.00% <100.00%> (ø)
...e/lang/typescript/TypeScriptPrecompiledLoader.java 68.49% <ø> (-3.44%) ⬇️
...m/internals/intrinsics/js/abort/AbortIntrinsics.kt 100.00% <100.00%> (ø)
...e/gvm/internals/intrinsics/js/abort/AbortSignal.kt 84.81% <100.00%> (+0.59%) ⬆️
... and 53 more

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53faf97...6309424. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix: resources located next to bin
fix: python vfs for lang resources
fix: python imports (don't fail due to unregistered unsafe allocation)
chore: add new ffm config
chore: cleanup redundant profiles and jars

Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon changed the title [wip] fix: vfs perf fix: vfs perf Mar 25, 2025
sgammon added 3 commits March 26, 2025 04:57
Relates to oracle/graal#10882

Signed-off-by: Sam Gammon <[email protected]>
chore: drop all symbols for js modules
chore: implement build-time intrinsics gathering
chore: impelment build-time polyfills parsing
chore: ffm config
chore: general cleanups

Signed-off-by: Sam Gammon <[email protected]>
@sgammon sgammon marked this pull request as ready for review March 27, 2025 10:13
@sgammon sgammon moved this from In Progress to Done in Elide Mar 27, 2025
@sgammon sgammon merged commit f386f6b into main Mar 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vfs Issues and PRs relating to virtual file system (VFS) features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Some Python stdlib modules don't import
2 participants