Ignore received EDUs if origin server in room ACL #18475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog.d/18475.feature
Outdated
| @@ -0,0 +1 @@ | |||
| Make ACLs apply to EDUs. | |||
There was a problem hiding this comment.
Do we have any tests for ACLs on
/sendanywhere? I can't seem to find any and don't want to waste time reinventing the wheel trying to add tests for these 2 cases.
There is tests/federation_acl_test.go in Complement
There was a problem hiding this comment.
Complement PR: matrix-org/complement#783
Co-authored-by: Eric Eastwood <[email protected]>
| @@ -551,6 +551,30 @@ async def _process_edu(edu_dict: JsonDict) -> None: | |||
| edu_type=edu_dict["edu_type"], | |||
| content=edu_dict["content"], | |||
| ) | |||
|
|
|||
| if edu.edu_type == EduTypes.TYPING: | |||
There was a problem hiding this comment.
For each of these cases, we should add a comment to mark the MSC that determines this behavior
// Server ACL's apply to `EduTypes.TYPING` per MSC4163
There was a problem hiding this comment.
That was a good suggestion, helped me figure out that we were rejecting the whole EDU instead of stripping read receipts for banned rooms only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: MSC4163: Make ACLs apply to EDUs
Part of #18118 to declare support for Matrix v1.13
Complement PR: matrix-org/complement#783
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.