Skip to content

Readme tweaks #18218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 2, 2025
Merged

Readme tweaks #18218

merged 7 commits into from
May 2, 2025

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Mar 6, 2025 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@AndrewFerr AndrewFerr requested a review from a team as a code owner March 6, 2025 17:13
anoadragon453
anoadragon453 requested changes Apr 30, 2025
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay in review here. A couple minor points below.

README.rst
Comment on lines +256 to +258
| Copyright 2014-2017 OpenMarket Ltd
| Copyright 2017 Vector Creations Ltd
| Copyright 2017-2025 New Vector Ltd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts each copyright on its own line; otherwise, they appear on one line.

AndrewFerr and others added 3 commits April 30, 2025 10:16
@AndrewFerr @anoadragon453
Separate final README paragraph
68e71ec 
Co-authored-by: Andrew Morgan <[email protected]>
@AndrewFerr
Add line break after copyright lines
f10a999
@AndrewFerr
Satisfy rstcheck
3a3864e 
Ensure line block ends with a blank line
@sandhose sandhose merged commit f2ca2e3 into element-hq:develop May 2, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anoadragon453 anoadragon453 anoadragon453 requested changes

@sandhose sandhose sandhose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrewFerr @anoadragon453 @sandhose