add image transparency and fix issues with gifs #2731
Conversation
|
I'm guessing you don't want to add jitpack as a new maven repo but I couldn't get it working without that change, so let me know if you have any ideas. Hopefully I can remove that line somehow. |
|
Hi @dkanada , |
| if (!mMediasCache.isMediaCached(mediaUrl, width, height, mimeType)) { | ||
| // display nothing | ||
| container.addView(view, 0); | ||
| return view; |
There was a problem hiding this comment.
This return has gone away, not sure it is intended. the actual code is so unclear...
There was a problem hiding this comment.
It was intended, I don't think it makes a difference but adding two views to the container can cause a crash. I was getting that crash a couple times while modifying the code, so I changed that section a bit. It should work the same as before, now there is just one path to add a view to the container and return.
|
Signed-off-by: Dillon Kanada [email protected] |
|
Somewhat related, I noticed that neither unencrypted nor e2e gifs get thumbnails in the event parameters. However, unencrypted rooms seem to supply a thumbnail while e2e rooms require a complete download. Are there multiple methods to set thumbnails for an event? |
I added the PhotoView dependency as mentioned in #2602 so I could fix the WebView issues and changed the background color to match the current theme.