modify some settings and update PreferencesManager

[dkanada]

This is related to issue #2436 and removes double negation in some of the settings. I also grouped the keys a bit more clearly in PreferencesManager and modified a couple other strings.

I tried to slim down some of the setting titles because I think it might be better in the future to explain the settings in the description and have more concise titles. One example is the inline URL previews, the title could just be Inline URL Previews and the description could explain that they will only be shown if your homeserver enables the feature.

[dkanada]

Is VectorPreferenceCategory used often? I was trying to figure out why the Labs category always has a bold title, turns out the custom category class sets text as bold, which I think looks a tad odd.

[bmarty]

Hi @dkanada ,

Thanks for the PR, look good. I've done several remarks

Benoît

Fixes #2436

[bmarty]

Also please fix errors reported by Travis

[bmarty]

Is VectorPreferenceCategory used often? I was trying to figure out why the Labs category always has a bold title, turns out the custom category class sets text as bold, which I think looks a tad odd.

I assume VectorPreferenceCategory should be used only in vector_room_settings_preferences.xml. Feel free to make the labs section is classical PreferenceCategory.

Also I wanted to let you know that I've started to migrate to preference from v7 support library. It's not done yet, but it will be in a near future.

[dkanada]

Signed-off-by: Dillon Kanada [email protected]

[bmarty]

Hi @dkanada ,

Thanks for the update. Everything looks perfect, except a wording that I didn't notice before.

Benoît