This repository was archived by the owner on Jan 30, 2025. It is now read-only.
several UI improvements for dialogs, video messages, and the previewer activity #2583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dkanada , Thanks for this new PR. Can you please sign-off and touch Also, CI report this error: Why have you removed the I will review the code soon. |
ganfra
reviewed
Sep 13, 2018
vector/src/main/java/im/vector/activity/MediaPreviewerActivity.java
Outdated
Show resolved
Hide resolved
|
Signed-off-by: Dillon Kanada [email protected] |
bmarty
suggested changes
Sep 13, 2018
vector/src/main/java/im/vector/fragments/VectorSettingsPreferencesFragment.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/adapters/VectorMessagesAdapter.java
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/activity/MediaPreviewerActivity.java
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/activity/MediaPreviewerActivity.java
Outdated
Show resolved
Hide resolved
vector/src/main/res/layout/dialog_phone_number_verification.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the first change was fixing the padding and other spacing issues on a lot of dialogs. I probably missed a few but at least the most commonly used ones are fixed. The font preference wasn't displaying the currently selected font size, it is working now.
I also implemented the play icon I was talking about instead of using the filetype icons for image and video messages. This is what the iOS client does, and I also think it makes more sense for end users.
The last changes were in the MediaPreviewerActivity, which is now much more functional with some modifications to the glide calls. Small images and gifs are properly scaled to fill the screen, images with a transparent background are working, gifs will now play instead of just showing a thumbnail, and the UI looks more polished.