modify notification icon #2492
modify notification icon #2492
Conversation
|
One thing to note, the link you used above mentioned a small amount of padding for the icons, and the material design guidelines mention padding as well for app icons, but there wasn't any on the old notification icon. On 24 pixel rectangular shapes the suggested amount was two pixels on each side of the rectangle. |
|
Hi @dkanada , Thanks for the PR. The 'R' is good, but we cannot see the 'I' included in the logo anymore. Isn't it possible to keep the 'I' visible? Maybe with a wired 'R'? Also, could you please sign-off it as per https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off, and add a line in CHANGES.rst Benoît |
|
Here are three different variations with the "i" included. I will order them by what I think looks best first, I don't have a background in design but I think the solid character or the first one directly below looks best. If you can think of improvements let me know, I wasn't able to figure out a good way to incorporate the "i" without making it look a bit odd. I am not sure how well the wire frame will scale with a low resolution. |
|
Thanks for the 3 proposals. I'll share this with the team tomorrow, and we will decide what we can do |
|
Hi @dkanada , The first proposal is good 👍 Please don't forget my 2 other requests (CHANGES.rst and Sign-Off) Benoît |
|
Before I finish up this pull request, I made a few more small changes just to see what you thought. I noticed the navigation drawer was also using the same pixelated icon, so I changed it to use this new icon. There were three different copies of the same icon at that point (permanent notification, normal notification, and transparent logo) so I just renamed all references to transparent logo since that is a good name for this icon. The messages and settings icons in the navigation drawer have always been slightly larger than the other three, and since I fixed the messages icon with padding I went ahead and fixed the settings icon as well. I used the default android settings icon which I grabbed from here which I think looks fine. Last item, the new transparent logo looks fine in the navigation drawer but looks a bit odd in the notification bar. I thought of one more possible design that might work. I actually like the transparent logo below in the navigation drawer, but using it as a notification icon is still really pixelated. Is there any chance just the notification icon could be switched over to a solid shape?
|
|
Hello @dkanada ,
Thanks! |
|
Signed-off-by: Dillon Kanada [email protected] |
|
Just removed the merge commit and rebased on develop, everything looks good now. |
|
Thanks for the update. Finally you've taken the last icon for the message menu as well, but it's ok, the entry should be removed in a near future, as it is totally useless... |
Update matrix-sdk.aar lib - build 1875 - Revision: ccf12449b8f09b06a7a8f501b9d7a382270b2305 Last rebase was performed June 1 2018. Here is the list of changes from vector-im/riot-android changes: Changes in Riot 0.8.XX (2018-08-24) =================================================== Features: - Manage server quota notices (#2440) Improvements: - Do not ask permission to write external storage at startup (#2483) - Update settings icon and transparent logo for notifications and navigation drawer (#2492) - URL previews are no longer requested from the server when displaying URL previews is disabled (PR #2514) - Fix some plural and puzzle strings, and remove other unused ones (#2444) - Manage System Alerts in a dedicated section Other changes: - Upgrade olm-sdk.aar from version 2.2.2 to version 2.3.0 - move PieFractionView from the SDK to the client (#2525) Bugfix: - Fix media sharing (#2530) - Fix notification sound issue in settings (#2524) - Disable app icon badge for "listen for event" notification (#2104) Changes in Riot 0.8.13 (2018-08-09) =================================================== Features: - Resurrect performance metrics (#2391) - Telemetry to report incidence of UISIs (#2330) - Add a previewer for previewing media before sending it into the room (#1742|#2445) - Implements ReplyTo feature (#2390) - Add auto completion for slash commands (#2384) - Support Room Versioning (#2441) Improvements: - Update matrix-sdk.aar lib (v0.9.7). - Piwik: Update the way how stats are reported (#2402) - Improve BugReport screen: display a preview of the screenshot (#2318) - In the settings, move theme settings just below "language" (#2439) - Improve the display of the sources of the message in the dialog (#2348) - Improve the display of the buttons and the reason in the room preview (#2352) - In the flair section on settings, notify the user when he has no flair (#2430) - Improve GDPR consent webview management (#2491) - Support external keyboard to send messages for recent devices (#220, #1279) - When user ignores or un-ignores someone, notify that the app will restart (#2437) Other changes: - Remove dependency to `android-gif-drawable` lib and use Glide to animate logo on Splashscreen (#2421) - Keep only Room.getState() method and remove Room.getLiveState() because they are similar (matrix-org/matrix-android-sdk#310) Bugfix: - Fix issue on incoming call screen when "Do not disturb mode" is active (#2417) - Fix issue when selecting sound for notifications in the settings - Fix issue when changing device name in the settings (#2416) - Fix issue on verifying device, update the wording of the description message (#1067) - Messages with code blocks show other HTML as plain text (#2280) - Message with <p> was sometimes not properly formatted (#2275) - Fix notification issue when Riot is not started (#2451) - Fix Unable to add Matrix apps (#2466) - Riot auto joined a public room (#2472) - Remove last traces of Firebase analytics (#2481) - code blocks are escaped and therefore hard readable (#2484) - Restore the navigation of the back button in the public rooms preview header (#2473) - Fix issue on preference screen: device lists was not displayed (#2409) - Ensure notification has a title (#2242) Changes in Riot 0.8.12 (2018-07-06) =================================================== Bugfix: - Fix issue on vanished favorite and low priority room (#2413) Changes in Riot 0.8.11 (2018-07-03) =================================================== Features: - Re-request keys manually for encrypted events (#2319) - Add option to send voice message to a room, using a third application to record message. To enable in the Labs settings (PR #1762) Improvements: - Update matrix-sdk.aar lib (v0.9.6). - New Floating Action Menu in Home screen (PR #2335) - Add spacing to device keys (#2314) - use apply() instead of commit() to save shared prefs (#2231) - Do not ring if "Do Not Disturb" is active (#1072) - Manage the "consent not given" error when declining a room invite Other changes: - Remove "Matrix application" activation from the Lab section in the settings (#2341) Bugfix: - Remove black borders on 18:9 phone (#2063) - Auto dismiss the join/reject room notification when user select an action (#2354) - Fix some crashes reported by the PlayStore (#2380, #2382, #2383, #2395) - Fix issues in UrlPreviews (#2312) Translations: - Galician thanks to Miguel Branco Build: - Add script to check code quality - Travis will now check if CHANGES.rst has been modified for each PR ------ Merge commit '94b7925a57b800db62b5ec87966d994ff53392b4' into develop # Conflicts: # vector/src/main/java/im/vector/activity/VectorRoomActivity.java # vector/src/main/java/im/vector/adapters/VectorMediasViewerAdapter.java # vector/src/main/java/im/vector/db/VectorContentProvider.java # vector/src/main/java/im/vector/dialogs/ConsentNotGivenHelper.kt # vector/src/main/java/im/vector/fragments/VectorSettingsPreferencesFragment.kt # vector/src/main/res/values/strings.xml # vector/src/main/res/values/styles.xml
|
@dkanada people like the icon you've created 👍 |
Mentioned in #530 about adding a solid icon for notifications on mobile. I took a vector of the logo and removed the inner three lines, then merged all the layers into one solid shape. The padding should be fine but let me know if it looks awkward, I used the normal amount for android icons.