This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Fix sticker display bug #2175
Merged
Fix sticker display bug #2175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
suggested changes
Apr 24, 2018
| } else { | ||
| downloadId = mMediasCache.downloadIdFromUrl(((ImageMessage) message).getUrl()); | ||
| } | ||
| } else if (!event.getType().equals(Event.EVENT_TYPE_STICKER) && (message instanceof ImageMessage)) { |
| } | ||
| } else if (!event.getType().equals(Event.EVENT_TYPE_STICKER) && (message instanceof ImageMessage)) { | ||
| downloadId = mMediasCache.downloadIdFromUrl(((ImageMessage) message).getUrl()); | ||
| } else if (event.getType().equals(Event.EVENT_TYPE_STICKER) && (message instanceof StickerMessage)) { |
There was a problem hiding this comment.
Remove test on event type and test if message is a StickerMessage before ImageMessage
|
Ok, please squash your commit before submitting your PR |
bmarty
approved these changes
Apr 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.