Ability to crop profile picture before setting

[anoadragon453]

Many social apps offer the ability to crop your profile picture from an image before setting it. Without this ability, users have to do so from a third-party app and it is a major introductory hassle when one is first making an account.

Having this ability in-app would thus be very useful.

Even better if it had a circle crop so you can see what it will actually look like.

[anoadragon453]

Yes, good point.

…

On September 20, 2018 2:18:35 PM UTC, Coffee ***@***.***> wrote: Even better if it had a circle crop so you can see what it will actually look like. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #2598 (comment)

[Martinc4321]

Hello I'm interested to add this functionality. May I try to implement it.

[anoadragon453]

@Martinc4321 This issue is labelled 'help wanted' so yes, feel free to contribute!,

[Martinc4321]

Thanks, I'm on it.

[anoadragon453]

Cool, thanks!

[anoadragon453]

How's your progress on this issue @Martinc4321?

[Martinc4321]

I've committed some changes. @anoadragon453

[Martinc4321]

I am not sure ,but what review proces u have. Do I i need to push it to branch ? Then to which one.

[bmarty]

Hello @Martinc4321,
You have forked the repository and commited changes on your version of the code. Once you have pushed your change to Github, you can then open a pull request to vector-im/riot-android and we will review what you have done.
Benoît

[Martinc4321]

@bmarty I created PR. I hope it will work. I didn't work with GIT through PR yet. If there will be any problems (probably there will be) please wrote them down I definitely try to fix them.