-
Notifications
You must be signed in to change notification settings - Fork 40
Registration tokens #4619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registration tokens #4619
Conversation
2f6ff5f
to
9726f35
Compare
Deploying matrix-authentication-service-docs with
|
Latest commit: |
12e9d02
|
Status: | ✅ Deploy successful! |
Preview URL: | https://da0f1f99.matrix-authentication-service-docs.pages.dev |
Branch Preview URL: | https://quenting-registration-tokens.matrix-authentication-service-docs.pages.dev |
crates/cli/src/commands/manage.rs
Outdated
token: Option<String>, | ||
|
||
/// Maximum number of times this token can be used. | ||
/// If not provided, the token can be used an unlimited number of times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm.. kind of feels like the sensible default would be 1, to be honest
(the word 'token' feels like something you 'spend', not something that would be infinite by default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. I've changed the behaviour of the CLI tool in e53e266
A build for this PR at commit 0f00bf0 has been created through the Z-Build-Workflow label by reivilibre. Docker image is available at:
Pre-built binaries are available through the workflow run artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool stuff
A build for this PR at commit cab8ba2 has been created through the Z-Build-Workflow label by sandhose. Docker image is available at:
Pre-built binaries are available through the workflow run artifacts. |
Very +1 to this concept. After MAS we have basically lost the "not SSO" registation method of https://github.com/zeratax/matrix-registration/ we used to use, as we have 12+ different hackerspaces to cater and not everyone have an SSO available for an reason or another, so a method of registation tokens would be awesome to support while MAS is at use. To say it most broadly, that Zeratax thing would still be just perfect as concept, but obviously it would need complete backend overhaul to use MAS instead. It has total server admin control of token use times and expiration dates etc. |
a401332
to
12e9d02
Compare
Fixes #3956
Fixes #4584
This can be reviewed commit by commit.
It includes an admin API to list/get/create/revoke tokens, as well as a CLI tool to issue a token.