remove prefix when forwarding the login_hint #4571
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can change this PR to add a configuration to |
mcalinghee
force-pushed
the
feat/login_hint_remove_prefix
branch
from
3454dea to
0770693
Compare
|
I'm not convinced we should specifically strip prefixes when forwarding login hints. Maybe @tonkku107 suggestion to have a minijinja template for this makes sense? So in this case, if you need to do the {{ login_hint | split("mxid:@") | reverse | first | split(":") | first }} |
mcalinghee
force-pushed
the
feat/login_hint_remove_prefix
branch
from
0770693 to
dc76bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to forward the login_hint with a mxid to the upstream providers thanks to #4512
We are using a prefix
mxidin the login_hint (login_hint is in the form ofmxid:@localpart:homeserver) to know the type of the login_hint.This prefix is useful between the MAS and their clients but on the upstream providers side, it is usually not supported unless we customize them.