init-secrets job #142
Merged
init-secrets job #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbz
reviewed
Jan 30, 2025
There was a problem hiding this comment.
Looks really good and matches what I had in mind.
I think I'd like initSecrets.enabled: true (or omitted as the default) on the <component>-minimal-values.yaml as those are our examples of what is minimally required. I imagine there's issues with the manifest tests though?
charts/matrix-stack/configs/matrix-authentication-service/config.yaml.tpl
Outdated
Show resolved
Hide resolved
benbz
reviewed
Jan 30, 2025
gaelgatelement
force-pushed
the
gaelg/matrix-tools-write-secret
branch
from
7614e69 to
2dbe596
Compare
benbz
reviewed
Jan 31, 2025
gaelgatelement
force-pushed
the
gaelg/matrix-tools-write-secret
branch
7 times, most recently
from
042bdd5 to
f520581
Compare
benbz
reviewed
Jan 31, 2025
gaelgatelement
force-pushed
the
gaelg/matrix-tools-write-secret
branch
from
f520581 to
3a5aec6
Compare
benbz
reviewed
Jan 31, 2025
gaelgatelement
force-pushed
the
gaelg/matrix-tools-write-secret
branch
8 times, most recently
from
e0a1c43 to
409294f
Compare
benbz
reviewed
Feb 4, 2025
- Add secret labels parameter to GenerateSecret function - Update secret creation and update logic to use new parameter - Validate if secret is managed by matrix-tools-init-secrets before updating - Adjust test cases to reflect new functionality - Refactor test case structure for clarity
- Validate secrets with new rules - Update job to pass generated secrets as labels - Modify service account conditionally based on secret generation - Simplify secret path resolution templates - Ensure consistent secret property checks across components
- Clarify required context properties in credentials template - Ensure init secrets are included when initSecrets enabled - Correctly reference postgres password secret property - Remove unnecessary job from service account test case - Simplify synapse statefulset init container configuration
gaelgatelement
force-pushed
the
gaelg/matrix-tools-write-secret
branch
5 times, most recently
from
b351657 to
8722622
Compare
gaelgatelement
force-pushed
the
gaelg/matrix-tools-write-secret
branch
from
8722622 to
960e15a
Compare
benbz
reviewed
Feb 6, 2025
Comment on lines
+7
to
+11
| matrixTools: | ||
| image: | ||
| pullPolicy: Never | ||
| digest: "" | ||
|
|
There was a problem hiding this comment.
Why is this needed in the EW integration test values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job is dedicated to initializing secrets when they are missing from the chart.
The job is enabled by default. It makes some secrets optional as they are going to be handled automatically during initial chart setup.
So far this PR makes the following secret optional :
synapse.macaroonThe PR adds 2 new helpers to include secrets in
matrix-toolsinit containers.