Skip to content

Improved a11y in CollapsibleRoomTimelineView #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 16, 2025

fixes #4207

@Velin92 Velin92 requested a review from a team as a code owner June 16, 2025 16:23
@Velin92 Velin92 added the A11y Accessibility label Jun 16, 2025
Copy link

github-actions bot commented Jun 16, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f0d45d4

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (7e801c3) to head (f0d45d4).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...imelineItemViews/CollapsibleRoomTimelineView.swift 18.75% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4208   +/-   ##
========================================
  Coverage    79.17%   79.17%           
========================================
  Files          798      798           
  Lines        74842    74855   +13     
========================================
+ Hits         59255    59270   +15     
+ Misses       15587    15585    -2     
Flag Coverage Δ
unittests 71.24% <18.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 added the pr-a11y for accessibility improvements. label Jun 16, 2025
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from the localizable key name.

@Velin92 Velin92 force-pushed the mauroromito/improve_a11y_in_grouped_state_events branch from 5e84292 to f0d45d4 Compare June 17, 2025 10:55
@Velin92 Velin92 merged commit 5b6f4a3 into develop Jun 17, 2025
5 checks passed
@Velin92 Velin92 deleted the mauroromito/improve_a11y_in_grouped_state_events branch June 17, 2025 10:56
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Accessibility pr-a11y for accessibility improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Improve accessibility for grouped state events in timeline
2 participants