Skip to content

Focus voice over automatically when focussing a timeline event #4206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 16, 2025

fixes #4205

@Velin92 Velin92 requested a review from a team as a code owner June 16, 2025 15:07
Copy link

@Velin92 Velin92 added the A11y Accessibility label Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1017 2 1015 0
View the full list of 2 ❄️ flaky tests
StartChatScreenViewModelTests::testJoinRoomByAddressFailsBecauseNotFound()

Flake rate in main: 10.00% (Passed 45 times, Failed 5 times)

Stack Traces | 10.1s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Other/Extensions/XCTestCase.swift:43)
DeferredFulfillmentTests::testObservableWithSynchronousUpdate()

Flake rate in main: 14.13% (Passed 79 times, Failed 13 times)

Stack Traces | 12s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 merged commit 7e801c3 into develop Jun 17, 2025
12 checks passed
@Velin92 Velin92 deleted the mauroromito/improve_focussed_event_voice_over branch June 17, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Accessibility pr-a11y
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Voice over should focus the highlighted event in the timeline automatically
2 participants