Skip to content

Improved the accessibility in PollFormScreen #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

Improved the accessibility in PollFormScreen #4200

merged 1 commit into from
Jun 16, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jun 13, 2025

fixes #4199

@Velin92
improved the accessibility labels for the view
154ff89 
also added copies for the section headers, and fixes an issue where the move action voice over was not reading the option
@Velin92 Velin92 requested a review from a team as a code owner June 13, 2025 16:39
@Velin92 Velin92 requested review from stefanceriu and removed request for a team June 13, 2025 16:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2025 •
edited
Loading

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 154ff89

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Jun 13, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1017 1 1016 0
View the full list of 1 ❄️ flaky tests 
DeferredFulfillmentTests::testObservableAsynchronousUpdate()

Flake rate in main: 14.77% (Passed 75 times, Failed 13 times)

Stack Traces | 11.1s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Velin92 Velin92 merged commit 670bb3a into develop Jun 16, 2025
10 checks passed
@Velin92 Velin92 deleted the mauroromito/improve_poll_form_screen_accessibility branch June 16, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
pr-a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Improve poll form screen accessibility
2 participants
@Velin92 @stefanceriu