Skip to content

Exclude protocol files from code coverage checks. #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

stefanceriu
Copy link
Member

Because they're generally uncoverable and there's no logic to them.

@stefanceriu stefanceriu requested a review from a team as a code owner June 13, 2025 12:22
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team June 13, 2025 12:22
@stefanceriu stefanceriu added the pr-misc for other changes label Jun 13, 2025
Copy link

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (f0d3e85) to head (0e93cbf).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4196      +/-   ##
===========================================
- Coverage    79.11%   78.93%   -0.18%     
===========================================
  Files          820      820              
  Lines        75144    75144              
===========================================
- Hits         59449    59317     -132     
- Misses       15695    15827     +132     
Flag Coverage Δ
unittests 71.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 7196768 into develop Jun 13, 2025
15 checks passed
@stefanceriu stefanceriu deleted the stefan/coverageExcludeProtocols branch June 13, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants