Skip to content

Allow multiple room info updates when receiving a call before deciding the room doesn't have an active call anymore #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

stefanceriu
Copy link
Member

No description provided.

…g the room doesn't have an active call anymore.
@stefanceriu stefanceriu requested a review from a team as a code owner June 4, 2025 08:51
@stefanceriu stefanceriu added the pr-change for updates to an existing feature label Jun 4, 2025
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team June 4, 2025 08:51
Copy link

github-actions bot commented Jun 4, 2025

Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against ceb77d9

Copy link

sonarqubecloud bot commented Jun 4, 2025

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.84%. Comparing base (cf6afcf) to head (ceb77d9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
NSE/Sources/NotificationHandler.swift 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4171      +/-   ##
===========================================
- Coverage    78.87%   78.84%   -0.04%     
===========================================
  Files          828      828              
  Lines        75241    75245       +4     
===========================================
- Hits         59345    59325      -20     
- Misses       15896    15920      +24     
Flag Coverage Δ
unittests 71.40% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit 97e23b5 into develop Jun 5, 2025
15 checks passed
@stefanceriu stefanceriu deleted the stefan/elementCallRoomInfoUpdates branch June 5, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants