Skip to content

Add a placeholder association for localhost in developer mode. #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 2, 2025

Just a nice quality-of-life tweak so we don't need to check the docs for the correct syntax for alternate modes.

Note: I didn't try this with localhost specifically (it just seemed the most obvious placeholder).

@pixlwave pixlwave requested a review from a team as a code owner June 2, 2025 11:02
@pixlwave pixlwave requested review from stefanceriu and removed request for a team June 2, 2025 11:02
Copy link

sonarqubecloud bot commented Jun 2, 2025

@pixlwave pixlwave added the pr-misc for other changes label Jun 2, 2025
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (1132ac8) to head (6c91f77).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4163      +/-   ##
===========================================
+ Coverage    78.81%   78.84%   +0.03%     
===========================================
  Files          828      828              
  Lines        75216    75216              
===========================================
+ Hits         59278    59302      +24     
+ Misses       15938    15914      -24     
Flag Coverage Δ
unittests 71.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@pixlwave pixlwave merged commit 401db03 into develop Jun 3, 2025
15 checks passed
@pixlwave pixlwave deleted the doug/universal-links branch June 3, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants