Skip to content

Adopt the new deduplicate room versions room list filter. #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented May 30, 2025

@stefanceriu stefanceriu requested a review from Velin92 May 30, 2025 13:23
@stefanceriu stefanceriu requested a review from a team as a code owner May 30, 2025 13:23
@stefanceriu stefanceriu added the pr-feature for a new feature label May 30, 2025
Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu enabled auto-merge (rebase) May 30, 2025 13:24
Copy link

Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against a366bef

Copy link

@stefanceriu stefanceriu merged commit 1f52546 into develop May 30, 2025
10 checks passed
@stefanceriu stefanceriu deleted the stefan/sdkBump branch May 30, 2025 13:40
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (458c6aa) to head (a366bef).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4160      +/-   ##
===========================================
- Coverage    78.84%   78.81%   -0.04%     
===========================================
  Files          828      828              
  Lines        75216    75216              
===========================================
- Hits         59304    59278      -26     
- Misses       15912    15938      +26     
Flag Coverage Δ
unittests 71.34% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants