Skip to content

Feature/fga/update rust sdk 0.1.37 #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Jul 27, 2023

Closes #968

This should fix #981

Also as fetchMembers can lock the timeline for some time, only call it after timeline is ready so opening is fast.

@ganfra ganfra marked this pull request as ready for review July 27, 2023 18:51
@ganfra ganfra requested a review from a team as a code owner July 27, 2023 18:51
@ganfra ganfra requested review from bmarty and removed request for a team July 27, 2023 18:51
@ElementBot
Copy link
Collaborator

ElementBot commented Jul 27, 2023

Warnings
⚠️

gradle/libs.versions.toml#L26 - A newer version of androidx.compose.compiler:compiler than 1.4.8 is available: 1.5.0

Generated by 🚫 dangerJS against 878aa39

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (5f35852) 56.69% compared to head (878aa39) 56.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #992      +/-   ##
===========================================
- Coverage    56.69%   56.68%   -0.01%     
===========================================
  Files          981      981              
  Lines        24897    24901       +4     
  Branches      5055     5055              
===========================================
  Hits         14116    14116              
- Misses        8544     8548       +4     
  Partials      2237     2237              
Files Changed Coverage Δ
...d/libraries/matrix/impl/room/RoomListExtensions.kt 0.00% <0.00%> (ø)
...aries/matrix/impl/room/RoomSummaryListProcessor.kt 0.00% <0.00%> (ø)
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt 0.00% <0.00%> (ø)
...ries/matrix/impl/room/RustRoomSummaryDataSource.kt 0.00% <ø> (ø)
...braries/matrix/impl/timeline/RustMatrixTimeline.kt 0.00% <0.00%> (ø)
.../timeline/item/event/TimelineEventContentMapper.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@@ -96,6 +96,7 @@ class TimelineEventContentMapper(private val eventMessageMapper: EventMessageMap
data = kind.msg.map()
)
}
else -> UnknownContent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add the 2 poll contents here explicitly with a TODO/FIXME?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @julioromano has already done it locally...

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
After opening and closing many times the same room, the app is becoming very slow... But I did not have any deadlock, so not blocking the PR for this.

@bmarty
Copy link
Member

bmarty commented Jul 27, 2023

Maestro is failing with:

java.lang.IllegalStateException: Room object has already been destroyed
07-27 21:09:18.370 E/AndroidRuntime( 6732): at org.matrix.rustcomponents.sdk.Room.id(matrix_sdk_ffi.kt:16579)

image

After the leave room dialog is cancelled :/

Not blocking the new SDK to be integrated though.

@bmarty bmarty merged commit 243cda2 into develop Jul 27, 2023
@bmarty bmarty deleted the feature/fga/update-rust-sdk-0.1.37 branch July 27, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock when opening a room.
4 participants