-
Notifications
You must be signed in to change notification settings - Fork 232
Feature/fga/update rust sdk 0.1.37 #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #992 +/- ##
===========================================
- Coverage 56.69% 56.68% -0.01%
===========================================
Files 981 981
Lines 24897 24901 +4
Branches 5055 5055
===========================================
Hits 14116 14116
- Misses 8544 8548 +4
Partials 2237 2237
☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed! |
@@ -96,6 +96,7 @@ class TimelineEventContentMapper(private val eventMessageMapper: EventMessageMap | |||
data = kind.msg.map() | |||
) | |||
} | |||
else -> UnknownContent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add the 2 poll contents here explicitly with a TODO/FIXME?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess @julioromano has already done it locally...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
After opening and closing many times the same room, the app is becoming very slow... But I did not have any deadlock, so not blocking the PR for this.
Closes #968
This should fix #981
Also as fetchMembers can lock the timeline for some time, only call it after timeline is ready so opening is fast.