Skip to content

Allow user with enough power level to redact other's messages (#969) #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jul 27, 2023

Closes #969

@bmarty bmarty requested a review from a team as a code owner July 27, 2023 16:43
@bmarty bmarty requested review from csmith and removed request for a team July 27, 2023 16:43
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage: 63.63% and no project coverage change.

Comparison is base (cd5b9ea) 56.67% compared to head (5b95bd0) 56.68%.
Report is 12 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #991   +/-   ##
========================================
  Coverage    56.67%   56.68%           
========================================
  Files          981      981           
  Lines        24888    24905   +17     
  Branches      5054     5056    +2     
========================================
+ Hits         14106    14117   +11     
- Misses        8544     8548    +4     
- Partials      2238     2240    +2     
Files Changed Coverage Δ
...ent/android/features/messages/impl/MessagesView.kt 59.35% <0.00%> (ø)
...nt/android/libraries/matrix/api/room/MatrixRoom.kt 33.33% <ø> (ø)
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt 0.00% <0.00%> (ø)
...ndroid/libraries/matrix/ui/room/MatrixRoomState.kt 28.57% <0.00%> (-21.43%) ⬇️
...es/messages/impl/actionlist/ActionListPresenter.kt 92.00% <83.33%> (+0.51%) ⬆️
...ndroid/features/messages/impl/MessagesPresenter.kt 83.66% <100.00%> (+0.21%) ⬆️
...nt/android/features/messages/impl/MessagesState.kt 100.00% <100.00%> (ø)
...id/features/messages/impl/MessagesStateProvider.kt 91.17% <100.00%> (+0.26%) ⬆️
...tures/messages/impl/actionlist/ActionListEvents.kt 100.00% <100.00%> (ø)
...trix/api/room/powerlevels/MatrixRoomPowerLevels.kt 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 36d2246 into develop Jul 28, 2023
@bmarty bmarty deleted the feature/bma/redactRegardingPowerLevel branch July 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let room admin delete any message
2 participants