Prepare update to Rust SDK 0.1.36 #966
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #966 +/- ##
===========================================
- Coverage 56.65% 56.62% -0.03%
===========================================
Files 978 978
Lines 24732 24745 +13
Branches 5012 5019 +7
===========================================
Hits 14012 14012
- Misses 8501 8512 +11
- Partials 2219 2221 +2
☔ View full report in Codecov by Sentry. |
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
| @@ -100,6 +101,8 @@ class RustMatrixTimeline( | |||
|
|
|||
| init { | |||
| Timber.d("Initialize timeline for room ${matrixRoom.roomId}") | |||
|
|
|||
| val rustTaskHandleBag = TaskHandleBag() | |||
| when (notificationEvent) { | ||
| is NotificationEvent.Timeline -> timelineEventToNotificationContentMapper.map(notificationEvent.event) | ||
| is NotificationEvent.Invite -> NotificationContent.StateEvent.RoomMemberContent( | ||
| userId = sessionId.value, |
There was a problem hiding this comment.
I am wondering why RoomMemberContent::userId is a String and not a UserId, but not blocking here.
| @@ -42,6 +42,8 @@ import org.matrix.rustcomponents.sdk.MessageType as RustMessageType | |||
|
|
|||
| class EventMessageMapper { | |||
|
|
|||
| private val timelineEventContentMapper by lazy { TimelineEventContentMapper() } | |||
There was a problem hiding this comment.
I do not think that it is useful to use by lazy here. Is there a reason I am missing? (not blocking)
There was a problem hiding this comment.
Cyclical dependencies: TimelineEventContentMapper would have an EventMessageMapper, which would in turn have an TimelineEventContentMapper, etc.
We could try to extract this to refactor this logic, but I'd rather do it in another PR so we can merge and test this version.
|
Kudos, SonarCloud Quality Gate passed! |
This PR upgrades to the Rust SDK v0.1.36.
Additional changes:
NotificationDatato work without the underlying event for invites.fetchMemberswhen exiting the room.