Skip to content

maplibre-compose allow customisation of location dot style #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

maplibre-compose allow customisation of location dot style #929

merged 1 commit into from
Jul 20, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Jul 20, 2023 •
edited
Loading

  • And style it according to our designs.

Related to:

maplibre-compose allow customisation of location dot style
94fcd97 
- And style it according to our designs.
@julioromano julioromano self-assigned this Jul 20, 2023
@julioromano julioromano requested a review from a team as a code owner July 20, 2023 09:45
@julioromano julioromano requested review from csmith and removed request for a team July 20, 2023 09:45
@ElementBot
Copy link
Collaborator

ElementBot commented Jul 20, 2023 •
edited
Loading

Warnings
⚠️

libraries/maplibre-compose/src/main/kotlin/io/element/android/libraries/maplibre/compose/MapboxMap.kt#L182 - Use AppCompatResources.getDrawable()

Generated by 🚫 dangerJS against 94fcd97

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.02 🎉

Comparison is base (156bf08) 56.59% compared to head (94fcd97) 56.61%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #929      +/-   ##
===========================================
+ Coverage    56.59%   56.61%   +0.02%     
===========================================
  Files          968      968              
  Lines        24570    24585      +15     
  Branches      4987     4987              
===========================================
+ Hits         13905    13919      +14     
- Misses        8456     8457       +1     
  Partials      2209     2209
Impacted Files Coverage Δ
...t/android/libraries/maplibre/compose/MapUpdater.kt 0.00% <0.00%> (ø)
...nt/android/libraries/maplibre/compose/MapboxMap.kt 4.25% <0.00%> (ø)
...ment/android/features/location/impl/MapDefaults.kt 96.00% <100.00%> (+1.55%) ⬆️
.../libraries/maplibre/compose/MapLocationSettings.kt 90.00% <100.00%> (+23.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@julioromano julioromano mentioned this pull request Jul 20, 2023
Closed
6 tasks
@julioromano julioromano merged commit e448bbb into develop Jul 20, 2023
@julioromano julioromano deleted the julioromano/blackLocationDot branch July 20, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmith csmith csmith approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julioromano @ElementBot @csmith