Skip to content

Refactor a custom alignment to its own modifier for readability. #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

julioromano
Copy link

No description provided.

@julioromano julioromano requested a review from a team as a code owner July 19, 2023 14:20
@julioromano julioromano self-assigned this Jul 19, 2023
@julioromano julioromano requested review from bmarty and jmartinesp and removed request for a team and bmarty July 19, 2023 14:20
@julioromano julioromano force-pushed the julioromano/locationRefactorModifier branch from 9a39fec to afb34d1 Compare July 19, 2023 14:21
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.01 🎉

Comparison is base (4162d16) 56.16% compared to head (afb34d1) 56.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #924      +/-   ##
===========================================
+ Coverage    56.16%   56.17%   +0.01%     
===========================================
  Files          966      967       +1     
  Lines        24539    24539              
  Branches      4982     4982              
===========================================
+ Hits         13782    13785       +3     
+ Misses        8576     8573       -3     
  Partials      2181     2181              
Impacted Files Coverage Δ
...ent/android/features/location/api/StaticMapView.kt 48.97% <0.00%> (+2.82%) ⬆️
.../location/api/internal/ModifierCenterBottomEdge.kt 100.00% <100.00%> (ø)
...id/features/location/impl/send/SendLocationView.kt 57.50% <100.00%> (-1.04%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julioromano julioromano merged commit f614895 into develop Jul 19, 2023
@julioromano julioromano deleted the julioromano/locationRefactorModifier branch July 19, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants