Skip to content

Add screenshots with ~1.5 lines long desc to expanded location view #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

Add screenshots with ~1.5 lines long desc to expanded location view #923

merged 2 commits into from
Jul 20, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Jul 19, 2023 •
edited
Loading

This will help in catching alignment regressions.

Related to:

@julioromano julioromano self-assigned this Jul 19, 2023
@julioromano julioromano requested a review from a team as a code owner July 19, 2023 14:02
@julioromano julioromano requested review from csmith and removed request for a team July 19, 2023 14:02
@julioromano julioromano mentioned this pull request Jul 19, 2023
Closed
6 tasks
@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@codecov
Copy link

codecov bot commented Jul 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 87.50% and no project coverage change.

Comparison is base (e8e4542) 56.61% compared to head (2184a74) 56.61%.

❗ Current head 2184a74 differs from pull request most recent head b59f467. Consider uploading reports for the commit b59f467 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #923   +/-   ##
========================================
  Coverage    56.61%   56.61%           
========================================
  Files          968      968           
  Lines        24583    24589    +6     
  Branches      4987     4987           
========================================
+ Hits         13917    13922    +5     
- Misses        8457     8458    +1     
  Partials      2209     2209
Impacted Files Coverage Δ
...es/location/impl/show/ShowLocationStateProvider.kt 84.61% <83.33%> (-0.24%) ⬇️
...id/features/location/impl/show/ShowLocationView.kt 54.21% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@julioromano julioromano requested a review from jmartinesp July 19, 2023 15:38
@csmith
Copy link
Contributor

csmith commented Jul 19, 2023 •
edited by jmartinesp
Loading

Good catch, but I'm not sure justifying the text is correct here. We want it centered, and if you have a description that wraps one or two words onto the second line it looks pretty bad:

Screenshot

I wonder why it's not centered properly - something to do with the overflow ellipses? 🤔

jmartinesp
jmartinesp reviewed Jul 20, 2023
View reviewed changes
...tion/impl/src/main/kotlin/io/element/android/features/location/impl/show/ShowLocationView.kt Outdated
@@ -138,12 +137,12 @@ fun ShowLocationView(
state.description?.let {
Text(
text = it,
textAlign = TextAlign.Center,
textAlign = TextAlign.Justify,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just use TextAlign.Start here, justify looks a bit weird, as @csmith mentioned.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TextAlign.Start doesn't change things much:
Screenshot 2023-07-20 at 09 33 46
Screenshot 2023-07-20 at 09 33 41
Screenshot 2023-07-20 at 09 33 38

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, I misunderstood it, you always want it centered, even if the text has several lines and overflows. It seems a bit weird to me, but in that case we should go back to center aligning the text and trying to figure out why we have that extra indentation instead.

@julioromano julioromano force-pushed the julioromano/descriptionAlignment branch from b5e7593 to c1a24f2 Compare July 20, 2023 11:29
@julioromano julioromano force-pushed the julioromano/descriptionAlignment branch from 2184a74 to 806e6e7 Compare July 20, 2023 13:11
@julioromano julioromano changed the title Location expanded view: Fix alignment of description Add screenshots with ~1.5 lines long desc to expanded location view Jul 20, 2023
@julioromano
Copy link
Author

julioromano commented Jul 20, 2023 •
edited
Loading

Ok I double checked with Callum so I left it as is, but I still added one screenshot with the second line half filled so that we can catch regressions on this. Screenshot recording is ongoing.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julioromano julioromano enabled auto-merge (squash) July 20, 2023 13:37
@julioromano julioromano merged commit c746981 into develop Jul 20, 2023
@julioromano julioromano deleted the julioromano/descriptionAlignment branch July 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp left review comments

@csmith csmith csmith approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julioromano @csmith @jmartinesp