Reduce filename size for screenshot test #844
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #844 +/- ##
========================================
Coverage 57.02% 57.02%
========================================
Files 1017 1017
Lines 25829 25819 -10
Branches 5187 5182 -5
========================================
- Hits 14729 14724 -5
Misses 8821 8821
+ Partials 2279 2274 -5
☔ View full report in Codecov by Sentry. |
| @@ -75,7 +75,7 @@ class ScreenshotTest { | |||
| ) | |||
|
|
|||
| @Test | |||
| fun preview_tests( | |||
| fun t( | |||
There was a problem hiding this comment.
We should make it clear with adequate comments why these methods and classes are named as such.
| @@ -55,7 +55,7 @@ import java.util.Locale | |||
| * my own needs for this sample. | |||
| */ | |||
| @RunWith(TestParameterInjector::class) | |||
| class ScreenshotTest { | |||
| class T { | |||
There was a problem hiding this comment.
We should make it clear with adequate comments why these methods and classes are named as such.
| @@ -15,7 +15,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| package io.element.android.tests.uitests | |||
| package ui | |||
There was a problem hiding this comment.
We should make it clear with adequate comments why these methods and classes are named as such.
There was a problem hiding this comment.
Yes, I will comment, but I do not want to trigger the CI again for this. Will do in a later PR (I promise!).
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -28,4 +28,8 @@ class ComponentTestPreview( | |||
| override val name: String = showkaseBrowserComponent.componentName | |||
|
|
|||
| override fun toString(): String = showkaseBrowserComponent.componentKey | |||
| // Strip package (Preview MUST all have a distinct name) | |||
There was a problem hiding this comment.
Can we keep this as a last resort? There is noway to detect such clashes at compile time so it will degrade the devx.
Can we just strip the common io.element.android from the pacakge name for now?
…enerate much shorter name for screenshot files.
bmarty
force-pushed
the
feature/bma/screenshotTest
branch
from
66ad170 to
4a01494
Compare
|
I have updated the PR with including @julioromano 's remarks. I will merge it once CI is happy to avoid merge conflict on the screenshot tests. |
|
Kudos, SonarCloud Quality Gate passed! |
For a better devX. Having long names is hiding the useful part of the name (the name of the View), for instance in PR review:
Now the names will look like:
This PR also contains small cleanup.