Display the "verification success" Snackbar only when the state is VerificationFlowState.Finished.
#811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erificationFlowState.Finished`. Apply the same fix for `displayLeftRoomMessage`
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #811 +/- ##
===========================================
- Coverage 57.08% 57.07% -0.01%
===========================================
Files 920 920
Lines 23399 23401 +2
Branches 4720 4720
===========================================
Hits 13357 13357
- Misses 7940 7942 +2
Partials 2102 2102
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the same fix for
displayLeftRoomMessageCloses #809
I have detected another issue: we can start the verification from the settings now and when complete, the snackbar will be displayed only when back to the room list. I will handle that separately. #812
Test: verify the session, cancel it, let it timeout, verify again, play a lot with it. Before the fix the Snackbar was displayed a lot. With the fix it is displayed only when the verification is successful.