Skip to content

Fix dependencies on test #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

Fix dependencies on test #4790

merged 1 commit into from
Jun 2, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 28, 2025

Content

  • Limit number of test dependencies to other impl modules
  • Remove unused test dependencies
  • Ensure unit test are in the correct module. A module should not test the classes of another module
  • Move Fake class to the test scope

Motivation and context

Cleaner architecture, more unit test

Screenshots / GIFs

No expected change

Tests

  • Running unit test should be enough

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner May 28, 2025 10:36
@bmarty bmarty added the PR-Misc For other changes label May 28, 2025
@bmarty bmarty requested review from ganfra and removed request for a team May 28, 2025 10:36
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kx2rLM

Copy link

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (5b9da3c) to head (0939d65).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4790   +/-   ##
========================================
  Coverage    80.40%   80.41%           
========================================
  Files         2143     2146    +3     
  Lines        56766    56780   +14     
  Branches      7119     7119           
========================================
+ Hits         45644    45657   +13     
  Misses        8685     8685           
- Partials      2437     2438    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmarty bmarty merged commit 2c96fb8 into develop Jun 2, 2025
35 of 36 checks passed
@bmarty bmarty deleted the feature/bma/fixDependencies branch June 2, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants