Skip to content

Hide Element Call entry point if Element Call service is not available. #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 26, 2025

Content

Hide Element Call entry point if Element Call service is not available.

Motivation and context

Give enterprise service the ability to disable Element Call depending on the configuration.

Screenshots / GIFs

Tests

  • Let DefaultEnterpriseService.isElementCallAvailable() return false instead of true
  • Build and run the app
  • Observe that it's not possible to start a call anymore

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Misc For other changes labels May 26, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 26, 2025
Copy link
Contributor

github-actions bot commented May 26, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ydZSnX

@bmarty bmarty force-pushed the feature/bma/hideElementCall branch from 9a23861 to f93bc5e Compare May 26, 2025 20:03
@bmarty bmarty marked this pull request as ready for review May 27, 2025 08:25
@bmarty bmarty requested a review from a team as a code owner May 27, 2025 08:25
@bmarty bmarty requested review from ganfra and removed request for a team May 27, 2025 08:25
Copy link

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.40%. Comparing base (f455085) to head (be65afd).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...ures/userprofile/impl/root/UserProfilePresenter.kt 66.66% 0 Missing and 4 partials ⚠️
...atures/enterprise/impl/DefaultEnterpriseService.kt 0.00% 1 Missing ⚠️
...ent/android/features/roomcall/api/RoomCallState.kt 50.00% 0 Missing and 1 partial ⚠️
...android/libraries/matrix/test/room/FakeBaseRoom.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4783      +/-   ##
===========================================
- Coverage    80.41%   80.40%   -0.01%     
===========================================
  Files         2144     2144              
  Lines        56748    56769      +21     
  Branches      7112     7120       +8     
===========================================
+ Hits         45632    45647      +15     
- Misses        8684     8685       +1     
- Partials      2432     2437       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 5b9da3c into develop May 27, 2025
32 of 34 checks passed
@bmarty bmarty deleted the feature/bma/hideElementCall branch May 27, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants