Change : RoomMember moderation #4779

ganfra · 2025-05-26T12:55:53Z

Content

Extract and rework the RoomMember moderation bottomsheet so you can kick, ban/unban a user/member

from the timeline
from the room member list

Now the BottomSheet will always be displayed, even if the only available action is "View profile".
If you have the power level to kick/ban, the action will be displayed, either enabled or disabled, following the other member power level. In case the other member can't be fetched (in big public room it can be very slow), then we assume we have the power to do the actions.

We'll probably add some actions later, so maybe the name Moderation will be changed.

Motivation and context

Closes #4555

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 24
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
You've made a self review of your PR

ElementBot · 2025-05-26T12:57:00Z

	Warnings
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L5 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L25 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L203 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L208 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L237 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L357 - For locale "cs" (Czech) the following quantity should also be defined: `many` (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L5 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L25 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L203 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L208 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L237 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L357 - For locale "sk" (Slovak) the following quantity should also be defined: `many` (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against 24c29c5

github-actions · 2025-05-26T13:07:51Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AifK5v

codecov · 2025-05-26T13:37:54Z

Codecov Report

Attention: Patch coverage is 88.77551% with 33 lines in your changes missing coverage. Please review.

Project coverage is 80.37%. Comparing base (be2d83b) to head (24c29c5).
Report is 28 commits behind head on develop.

Files with missing lines	Patch %	Lines
...mmembermoderation/impl/RoomMemberModerationView.kt	84.12%	2 Missing and 8 partials ⚠️
...ermoderation/impl/RoomMemberModerationPresenter.kt	91.08%	0 Missing and 9 partials ⚠️
...ration/impl/DefaultRoomMemberModerationRenderer.kt	0.00%	7 Missing ⚠️
...ndroid/features/messages/impl/MessagesPresenter.kt	60.00%	2 Missing ⚠️
.../api/timeline/item/event/ProfileTimelineDetails.kt	33.33%	1 Missing and 1 partial ⚠️
...oomdetails/impl/members/RoomMemberListPresenter.kt	80.00%	1 Missing ⚠️
...res/roomdetails/impl/members/RoomMemberListView.kt	50.00%	0 Missing and 1 partial ⚠️
.../impl/InternalRoomMemberModerationStateProvider.kt	98.21%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4779      +/-   ##
===========================================
- Coverage    80.42%   80.37%   -0.06%     
===========================================
  Files         2144     2149       +5     
  Lines        56771    56855      +84     
  Branches      7120     7128       +8     
===========================================
+ Hits         45660    45696      +36     
- Misses        8674     8713      +39     
- Partials      2437     2446       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bmarty

LGTM and tested OK using the CI build. Thanks!

bmarty · 2025-05-27T08:35:52Z

.../snapshots/images/features.roommembermoderation.impl_RoomMemberModerationView_Night_2_en.png

I do not see such disabled state on the Figma. Is it OK?

Yes, it's not designed but this has been discussed in the room.

bmarty · 2025-05-27T08:51:18Z

features/roommembermoderation/api/build.gradle.kts

+
+dependencies {
+    implementation(projects.libraries.architecture)
+    implementation(projects.libraries.designsystem)


I think this dependency can be removed.

No, it's used

bmarty · 2025-05-27T08:51:23Z

features/roommembermoderation/api/build.gradle.kts

+dependencies {
+    implementation(projects.libraries.architecture)
+    implementation(projects.libraries.designsystem)
+    implementation(projects.libraries.uiStrings)


I think this dependency can be removed.

No, it's used

bmarty · 2025-05-27T08:52:18Z

.../kotlin/io/element/android/features/roommembermoderation/api/RoomMemberModerationRenderer.kt

@@ -0,0 +1,21 @@
+/*
+ * Copyright 2025 New Vector Ltd.


2025? There are other new files with 2024. This is maybe because some files has been moved and git see them as new files and previous files as deleted files?

I think it should be 2025 for all files in this module, as I've rewritten all the code in the end.

bmarty · 2025-05-27T09:06:40Z

...otlin/io/element/android/features/roommembermoderation/impl/RoomMemberModerationPresenter.kt

+            }
+            if (canBan) {
+                if (membership == RoomMembershipState.BAN) {
+                    add(ModerationActionState(action = ModerationAction.UnbanUser, isEnabled = canModerateThisUser))


Sorry, I have forgotten: the code coverage is decreasing a bit, maybe cover this line by a unit test?

sonarqubecloud · 2025-06-03T12:27:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ganfra added 9 commits May 14, 2025 11:19

change (member moderation) : extract in a separate module

58d9b12

change (member moderation) : branch moderation on timeline

a09cc8d

change (member moderation) : allow disabled action and render unban too

e405bf8

change (member moderation) : fix all existing tests

0b6c596

change (member moderation) : sync strings

b1441e1

change (member moderation) : clean and add tests on Presenter

1ac5674

Merge branch 'develop' into feature/fga/user_moderation_bottomsheet

2e1eb90

change (member moderation) : add test on RoomMemberModerationView

5eef211

change (member moderation) : clean up

37bf88d

ganfra added the PR-Change For updates to an existing feature label May 26, 2025

ganfra changed the title ~~Feature : RoomMember moderation~~ Change : RoomMember moderation May 26, 2025

ganfra marked this pull request as ready for review May 26, 2025 12:56

ganfra requested a review from a team as a code owner May 26, 2025 12:56

ganfra requested review from bmarty and removed request for a team May 26, 2025 12:56

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 26, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label May 26, 2025

Update screenshots

5625e28

bmarty approved these changes May 27, 2025

View reviewed changes

bmarty reviewed May 27, 2025

View reviewed changes

ganfra added 3 commits June 3, 2025 10:46

Merge branch 'develop' into feature/fga/user_moderation_bottomsheet

abc5547

change (room member moderation) : fix copyright

54fceaa

change (room member moderation) : add unban action test

a92748d

ganfra enabled auto-merge June 3, 2025 10:06

change (room member moderation) : sync translations

c8c5b85

ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 3, 2025

github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 3, 2025

Update screenshots

24c29c5

ganfra merged commit 4539474 into develop Jun 3, 2025
28 of 29 checks passed

ganfra deleted the feature/fga/user_moderation_bottomsheet branch June 3, 2025 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Change : RoomMember moderation #4779

Change : RoomMember moderation #4779

Uh oh!

ganfra commented May 26, 2025

Uh oh!

ElementBot commented May 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 26, 2025 •

edited

Loading

Uh oh!

codecov bot commented May 26, 2025 •

edited

Loading

Uh oh!

bmarty left a comment

Uh oh!

bmarty May 27, 2025

Uh oh!

ganfra Jun 3, 2025

Uh oh!

bmarty May 27, 2025

Uh oh!

ganfra Jun 3, 2025

Uh oh!

bmarty May 27, 2025

Uh oh!

ganfra Jun 3, 2025

Uh oh!

bmarty May 27, 2025

Uh oh!

ganfra Jun 3, 2025 •

edited

Loading

Uh oh!

bmarty May 27, 2025

Uh oh!

sonarqubecloud bot commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

Change : RoomMember moderation #4779

Change : RoomMember moderation #4779

Uh oh!

Conversation

ganfra commented May 26, 2025

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

ElementBot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bmarty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ganfra Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jun 3, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

ElementBot commented May 26, 2025 •

edited

Loading

github-actions bot commented May 26, 2025 •

edited

Loading

codecov bot commented May 26, 2025 •

edited

Loading

ganfra Jun 3, 2025 •

edited

Loading