Merge on boarding module to login module #4746
Conversation
| val confirmAccountProvider = backstack.elements.value.firstOrNull { | ||
| it.key.navTarget is NavTarget.ConfirmAccountProvider | ||
| }?.key?.navTarget ?: NavTarget.ConfirmAccountProvider(isAccountCreation = false) | ||
| backstack.singleTop(confirmAccountProvider) |
There was a problem hiding this comment.
There is maybe a better way to do this, but it works...
| private val loginEntryPoint: LoginEntryPoint, | ||
| private val notLoggedInImageLoaderFactory: NotLoggedInImageLoaderFactory, | ||
| ) : BaseFlowNode<NotLoggedInFlowNode.NavTarget>( | ||
| backstack = BackStack( | ||
| initialElement = NavTarget.OnBoarding, | ||
| initialElement = NavTarget.Root, |
There was a problem hiding this comment.
This node could be simplified more, since there is no need for a backstack anymore, but it can stay like this.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4746 +/- ##
===========================================
+ Coverage 80.13% 80.15% +0.01%
===========================================
Files 2129 2127 -2
Lines 56449 56436 -13
Branches 7055 7055
===========================================
Hits 45236 45236
+ Misses 8795 8782 -13
Partials 2418 2418 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Content
Merge on boarding module to login module.
Motivation and context
Be able to start the login flow straight away from the onboarding screen as below:
Screenshots / GIFs
No change in UI or flow, this is just preparatory work.
Tests
Tested devices
Checklist