Skip to content

Use the right live timeline instance in RustRoomFactory #4745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 20, 2025

Use `fullRoomWithTimeline` instead

770abd7
Select commit
Loading
Failed to load commit list.
Merged

Use the right live timeline instance in RustRoomFactory #4745

Use `fullRoomWithTimeline` instead
770abd7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed May 20, 2025 in 0s

0.00% of diff hit (target 80.13%)

View this Pull Request on Codecov

0.00% of diff hit (target 80.13%)

Annotations

Check warning on line 83 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L83 

Added line #L83 was not covered by tests

Check warning on line 89 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L89 

Added line #L89 was not covered by tests

Check warning on line 93 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L93 

Added line #L93 was not covered by tests

Check warning on line 97 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L97 

Added line #L97 was not covered by tests

Check warning on line 117 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L117 

Added line #L117 was not covered by tests

Check warning on line 121 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L121 

Added line #L121 was not covered by tests

Check warning on line 124 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L124 

Added line #L124 was not covered by tests

Check warning on line 132 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L132 

Added line #L132 was not covered by tests

Check warning on line 141 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L141 

Added line #L141 was not covered by tests

Check warning on line 153 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L153 

Added line #L153 was not covered by tests

Check warning on line 157 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L157 

Added line #L157 was not covered by tests

Check warning on line 162 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L161-L162 

Added lines #L161 - L162 were not covered by tests

Check warning on line 165 in libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt

See this annotation in the file changed.

@codecov codecov / codecov/patch

libraries/matrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustRoomFactory.kt#L165 

Added line #L165 was not covered by tests
View more details on Codecov