Skip to content

Allow configuration to provide multiple account providers. #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 19, 2025

Content

Allow configuration to provide multiple account providers.

No UI change for now, and Element X is still defaulting to matrix.org.

Motivation and context

Be mode flexible on the application configuration.

Screenshots / GIFs

No change expected

Tests

  • Login flow still work as expected.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner May 19, 2025 13:35
@bmarty bmarty requested review from ganfra and removed request for a team May 19, 2025 13:35
@bmarty bmarty added the PR-Misc For other changes label May 19, 2025
Copy link
Contributor

github-actions bot commented May 19, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/AcLhWz

@bmarty bmarty enabled auto-merge (squash) May 19, 2025 20:47
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.11%. Comparing base (f6cbca4) to head (cb03c91).
Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
...eaccountprovider/ChangeAccountProviderPresenter.kt 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4742   +/-   ##
========================================
  Coverage    80.10%   80.11%           
========================================
  Files         2129     2129           
  Lines        56411    56420    +9     
  Branches      7050     7051    +1     
========================================
+ Hits         45190    45199    +9     
  Misses        8805     8805           
  Partials      2416     2416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty disabled auto-merge May 20, 2025 06:56
@bmarty bmarty merged commit 3cf8237 into develop May 20, 2025
23 of 24 checks passed
@bmarty bmarty deleted the feature/bma/multiHomeServer branch May 20, 2025 06:57
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants