Skip to content

Reduce API of JoinedRoom, caller must use the Timeline API from liveTimeline instead #4731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 16, 2025

Content

Reduce API of JoinedRoom, caller must use the Timeline API from liveTimeline instead

Motivation and context

Removes lots of boilerplate code
Improve test coverage.

image

Screenshots / GIFs

Tests

  • No particular thing to check

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

…imeline instead.

This removes lots of boilerplate code.
@bmarty bmarty requested a review from a team as a code owner May 16, 2025 07:54
@bmarty bmarty requested review from ganfra and removed request for a team May 16, 2025 07:54
@bmarty bmarty added the PR-Misc For other changes label May 16, 2025
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/tGm4Kh

Copy link

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 79.03226% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.29%. Comparing base (11ac725) to head (be70b58).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...oid/libraries/matrix/test/timeline/FakeTimeline.kt 79.64% 22 Missing and 1 partial ⚠️
...features/poll/impl/actions/DefaultEndPollAction.kt 0.00% 1 Missing ⚠️
...poll/impl/actions/DefaultSendPollResponseAction.kt 0.00% 1 Missing ⚠️
...ment/android/features/share/impl/SharePresenter.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4731      +/-   ##
===========================================
+ Coverage    80.13%   80.29%   +0.15%     
===========================================
  Files         2129     2129              
  Lines        56449    56334     -115     
  Branches      7055     7056       +1     
===========================================
- Hits         45236    45232       -4     
+ Misses        8795     8685     -110     
+ Partials      2418     2417       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty merged commit 8d11521 into develop May 20, 2025
37 of 39 checks passed
@bmarty bmarty deleted the feature/bma/reduceRoomApi branch May 20, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants