Fix issues on JoinedRoom / BaseRoom

[bmarty]

Content

This PR fixes issue detected in the code that could lead to leak.
It may fixes issue related to incoming call not cancelled when answered else where, as well as other issues where the room state was observed.

Motivation and context

Stable code.

Screenshots / GIFs

Tests

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ZWcgfk

[bmarty]

Note: this test is failing if roomCoroutineScope (child of sessionCoroutineScope) is not cancelled.

[jmartinesp]

You could also probably double check rustBaseRoom.roomCoroutineScope.isActive.

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (9c69718) to head (1c80aa6).
Report is 8 commits behind head on develop.

Files with missing lines	Patch %	Lines
...android/libraries/matrix/impl/room/RustBaseRoom.kt	60.00%	2 Missing ⚠️
...roid/libraries/matrix/impl/room/RustRoomFactory.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4724      +/-   ##
===========================================
+ Coverage    80.09%   80.12%   +0.03%     
===========================================
  Files         2129     2129              
  Lines        56416    56413       -3     
  Branches      7052     7052              
===========================================
+ Hits         45188    45203      +15     
+ Misses        8811     8793      -18     
  Partials      2417     2417              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ganfra]

Thanks for the fixes!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud