Skip to content

Remove event cache feature flag #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

Remove event cache feature flag #4719

merged 2 commits into from
May 15, 2025

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented May 14, 2025 •
edited
Loading

Content

What the title says. Also remove associated conditionals.

Motivation and context

Clean up after #4716

Screenshots / GIFs

The should be no changes.

Tests

There should be no feature flag anymore and the 'clear room cache' action should be visible as long as the developer options are enabled.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@jmartinesp jmartinesp requested a review from a team as a code owner May 14, 2025 11:01
@jmartinesp jmartinesp requested review from ganfra and removed request for a team May 14, 2025 11:01
@jmartinesp jmartinesp added the PR-Misc For other changes label May 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YxEKVK

@jmartinesp
Remove event cache feature flag
95b9bb9 
Also remove associated conditionals.
@jmartinesp jmartinesp force-pushed the misc/remove-event-cache-feature-flag branch from 672c6e7 to 95b9bb9 Compare May 14, 2025 11:14
bmarty
bmarty reviewed May 14, 2025
View reviewed changes
...roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListPresenter.kt
@@ -263,8 +263,6 @@ class RoomListPresenter @Inject constructor(
isFavorite = event.roomSummary.isFavorite,
markAsUnreadFeatureFlagEnabled = featureFlagService.isFeatureEnabled(FeatureFlags.MarkAsUnread),
hasNewContent = event.roomSummary.hasNewContent,
eventCacheFeatureFlagEnabled = appPreferencesStore.isDeveloperModeEnabledFlow().first() &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too much removal, I think we should keep the test appPreferencesStore.isDeveloperModeEnabledFlow().first()

bmarty
bmarty reviewed May 14, 2025
View reviewed changes
...omlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListContextMenu.kt Outdated
style = ListItemStyle.Primary,
)
}
ListItem(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be displayed only in developer mode

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented May 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.09%. Comparing base (9234de6) to head (599ff9e).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...roid/features/roomlist/impl/RoomListContextMenu.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #4719      +/-   ##
===========================================
- Coverage    80.09%   80.09%   -0.01%     
===========================================
  Files         2129     2129              
  Lines        56416    56409       -7     
  Branches      7052     7051       -1     
===========================================
- Hits         45188    45181       -7     
  Misses        8811     8811              
  Partials      2417     2417

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bmarty
bmarty approved these changes May 15, 2025
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@jmartinesp jmartinesp merged commit 9f39ad8 into develop May 15, 2025
30 of 31 checks passed
@jmartinesp jmartinesp deleted the misc/remove-event-cache-feature-flag branch May 15, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ganfra ganfra Awaiting requested review from ganfra ganfra is a code owner automatically assigned from element-hq/element-x-android-reviewers

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmartinesp @bmarty