-
Notifications
You must be signed in to change notification settings - Fork 226
Change (report room) : check if server supports the report room api #4718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -100,6 +99,8 @@ class JoinRoomPresenter @AssistedInject constructor( | |||
val hideInviteAvatars by remember { | |||
appPreferencesStore.getHideInviteAvatarsFlow() | |||
}.collectAsState(initial = false) | |||
val canReportRoom by produceState(false) { value = matrixClient.canReportRoom() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create extension to avoid code duplication?
@Composable
fun MatrixClient.canReportRoomAsState() = produceState(false) { value = canReportRoom() }
Not blocking though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd not call this code duplication, but as you want
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4718 +/- ##
===========================================
- Coverage 80.16% 80.15% -0.01%
===========================================
Files 2126 2126
Lines 56313 56322 +9
Branches 7021 7022 +1
===========================================
+ Hits 45141 45146 +5
- Misses 8761 8765 +4
Partials 2411 2411 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Content
What the title says.
Motivation and context
Final bit for #4315
Screenshots / GIFs
No ui change.
Tests
Tested devices
Checklist